Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754877AbdC2IwT (ORCPT ); Wed, 29 Mar 2017 04:52:19 -0400 Received: from mga02.intel.com ([134.134.136.20]:20476 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753164AbdC2IwR (ORCPT ); Wed, 29 Mar 2017 04:52:17 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,240,1486454400"; d="scan'208";a="1113218572" From: "Huang\, Ying" To: Andrew Morton Cc: "Huang\, Ying" , , , Hugh Dickins , Shaohua Li , Minchan Kim , Rik van Riel , Andrea Arcangeli , "Kirill A . Shutemov" , Vladimir Davydov , Johannes Weiner , Michal Hocko Subject: Re: [PATCH -mm -v7 0/9] THP swap: Delay splitting THP during swapping out References: <20170328053209.25876-1-ying.huang@intel.com> <20170328151358.80a14e40d1a431084bc27db4@linux-foundation.org> Date: Wed, 29 Mar 2017 16:52:12 +0800 In-Reply-To: <20170328151358.80a14e40d1a431084bc27db4@linux-foundation.org> (Andrew Morton's message of "Tue, 28 Mar 2017 15:13:58 -0700") Message-ID: <87shlwtqgz.fsf@yhuang-dev.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1634 Lines: 41 Hi, Andrew, Andrew Morton writes: > On Tue, 28 Mar 2017 13:32:00 +0800 "Huang, Ying" wrote: > >> Hi, Andrew, could you help me to check whether the overall design is >> reasonable? >> >> Hi, Hugh, Shaohua, Minchan and Rik, could you help me to review the >> swap part of the patchset? Especially [1/9], [3/9], [4/9], [5/9], >> [6/9], [9/9]. >> >> Hi, Andrea could you help me to review the THP part of the patchset? >> Especially [2/9], [7/9] and [8/9]. >> >> Hi, Johannes, Michal and Vladimir, I am not very confident about the >> memory cgroup part, especially [2/9]. Could you help me to review it? >> >> And for all, Any comment is welcome! >> >> >> Recently, the performance of the storage devices improved so fast that >> we cannot saturate the disk bandwidth with single logical CPU when do >> page swap out even on a high-end server machine. Because the >> performance of the storage device improved faster than that of single >> logical CPU. And it seems that the trend will not change in the near >> future. On the other hand, the THP becomes more and more popular >> because of increased memory size. So it becomes necessary to optimize >> THP swap performance. > > I'll merge this patchset for testing purposes, but I don't believe that > it has yet had sufficient review. And thanks for drawing our attention > to those parts where you believe close review is needed - that helps. Thanks a lot for your help! I believe the patchset will be better tested in -mm tree. And hope people will have time to review it more closely. Best Regards, Huang, Ying