Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932190AbdC2KYr (ORCPT ); Wed, 29 Mar 2017 06:24:47 -0400 Received: from mail-oi0-f46.google.com ([209.85.218.46]:35179 "EHLO mail-oi0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932124AbdC2KYo (ORCPT ); Wed, 29 Mar 2017 06:24:44 -0400 MIME-Version: 1.0 In-Reply-To: <18560c7a-c9c5-1cf1-2e74-cf28c3a16b97@codeaurora.org> References: <1490108070-24061-1-git-send-email-shankerd@codeaurora.org> <1932728.uFK6bUjlgv@aspire.rjw.lan> <6b298342-2746-f6d5-0b0e-67c20fd4c002@codeaurora.org> <13204058.j7zPSh58G6@aspire.rjw.lan> <18560c7a-c9c5-1cf1-2e74-cf28c3a16b97@codeaurora.org> From: "Rafael J. Wysocki" Date: Wed, 29 Mar 2017 12:24:42 +0200 X-Google-Sender-Auth: ugdhWWOw5pCtbzUeQwzUWn_NoKw Message-ID: Subject: Re: [PATCH] ACPI : Update platform device numa node based on _PXM method To: shankerd@codeaurora.org Cc: "Rafael J. Wysocki" , Len Brown , linux-acpi , linux-kernel , Vikram Sethi Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1707 Lines: 39 On Wed, Mar 29, 2017 at 12:51 AM, Shanker Donthineni wrote: > Hi Rafael, > > > On 03/28/2017 05:15 PM, Rafael J. Wysocki wrote: >> On Tuesday, March 28, 2017 05:14:13 PM Shanker Donthineni wrote: >>> Hi Rafael, >>> >>> >>> On 03/28/2017 04:43 PM, Rafael J. Wysocki wrote: >>>> On Tuesday, March 21, 2017 09:54:30 AM Shanker Donthineni wrote: >>>>> The optional _PXM method evaluates to an integer that identifies the >>>>> proximity domain of a device object. This patch implements support for >>>>> ACPI _PXM method and updates the platform device numa node id using >>>>> acpi_get_node(), which provides the PXM to NUMA mapping information. >>>>> >>>>> Signed-off-by: Shanker Donthineni >>>> What exactly is the motivation here? >>> We have a couple of platform devices some of them are attached >>> to socket0 and others to a different socket. We would like to covert >>> memory allocations in Qualcomm platform device drivers to a NUMA >>> aware allocation to improve performance. >> All of the above information should be there in the patch changelog and >> presumably the patch should be a part of a larger series so the way this >> feature is going to be used is more clear. > > Sorry, I didn't quite get what's larger series? I'm happy to include above information in > commit/changelog text. We are trying to allocate memory using standard function > devm_kmalloc() but the function is always allocating memory from NUMA node 0. > The inline function dev_to_node(dev) always returns -1 on our system even though > we are setting PXM method in ACPI DSDT to non-zero value. OK So please add the above to the patch changelog too. Thanks, Rafael