DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 2201161D01
Date: Wed, 29 Mar 2017 06:46:27 -0400 (EDT)
From: Pankaj Gupta <pagupta@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>, kvm@vger.kernel.org,
        virtualization@lists.linux-foundation.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Message-ID: <674632255.8752546.1490784387956.JavaMail.zimbra@redhat.com>
In-Reply-To: <bf511f4a-b1d0-d732-a01e-9cd4b8ae6817@redhat.com>
References: <1490069087-4783-1-git-send-email-jasowang@redhat.com> <1490069087-4783-8-git-send-email-jasowang@redhat.com> <20170322155111-mutt-send-email-mst@kernel.org> <f41bb12f-10d6-9fb2-1cd2-76e3e9460aff@redhat.com> <bf511f4a-b1d0-d732-a01e-9cd4b8ae6817@redhat.com>
Subject: Re: [PATCH net-next 7/8] vhost_net: try batch dequing from skb
 array
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8BIT
Thread-Topic: vhost_net: try batch dequing from skb array
Thread-Index: +Ouu4NanvWjZ2XO8jw0oGrijoOJPfg==
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 636
Lines: 29

Hi Jason,

> 
> On 2017年03月23日 13:34, Jason Wang wrote:
> >
> >
> >>
> >>> +{
> >>> +    if (rvq->rh != rvq->rt)
> >>> +        goto out;
> >>> +
> >>> +    rvq->rh = rvq->rt = 0;
> >>> +    rvq->rt = skb_array_consume_batched_bh(rvq->rx_array, rvq->rxq,
> >>> +                        VHOST_RX_BATCH);
> >> A comment explaining why is is -bh would be helpful.
> >
> > Ok.
> >
> > Thanks
> 
> Rethink about this. It looks like -bh is not needed in this case since
> no consumer run in bh.

In that case do we need other variants of "ptr_ring_consume_batched_*()" functions.
Are we planning to use them in future? 

> 
> Thanks
>