DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 26EA58FCE1
Subject: Re: [PATCH net-next 7/8] vhost_net: try batch dequing from skb array
To: Pankaj Gupta <pagupta@redhat.com>
References: <1490069087-4783-1-git-send-email-jasowang@redhat.com>
 <1490069087-4783-8-git-send-email-jasowang@redhat.com>
 <20170322155111-mutt-send-email-mst@kernel.org>
 <f41bb12f-10d6-9fb2-1cd2-76e3e9460aff@redhat.com>
 <bf511f4a-b1d0-d732-a01e-9cd4b8ae6817@redhat.com>
 <674632255.8752546.1490784387956.JavaMail.zimbra@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>, kvm@vger.kernel.org,
        virtualization@lists.linux-foundation.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
From: Jason Wang <jasowang@redhat.com>
Message-ID: <cea3d380-389e-d258-915a-3d4f60232535@redhat.com>
Date: Wed, 29 Mar 2017 18:53:27 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <674632255.8752546.1490784387956.JavaMail.zimbra@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 853
Lines: 32


On 2017年03月29日 18:46, Pankaj Gupta wrote:
> Hi Jason,
>
>> On 2017年03月23日 13:34, Jason Wang wrote:
>>>
>>>>> +{
>>>>> +    if (rvq->rh != rvq->rt)
>>>>> +        goto out;
>>>>> +
>>>>> +    rvq->rh = rvq->rt = 0;
>>>>> +    rvq->rt = skb_array_consume_batched_bh(rvq->rx_array, rvq->rxq,
>>>>> +                        VHOST_RX_BATCH);
>>>> A comment explaining why is is -bh would be helpful.
>>> Ok.
>>>
>>> Thanks
>> Rethink about this. It looks like -bh is not needed in this case since
>> no consumer run in bh.
> In that case do we need other variants of "ptr_ring_consume_batched_*()" functions.
> Are we planning to use them in future?

I think we'd better keep them, since it serves as helpers. You can see 
that not all the helpers in ptr_ring has real users, but they were 
prepared for the future use.

Thanks

>
>> Thanks
>>