Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756098AbdC2NCU (ORCPT ); Wed, 29 Mar 2017 09:02:20 -0400 Received: from mga01.intel.com ([192.55.52.88]:63661 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755295AbdC2NCT (ORCPT ); Wed, 29 Mar 2017 09:02:19 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,241,1486454400"; d="scan'208";a="66421287" From: "Liang, Kan" To: Thomas Gleixner CC: "peterz@infradead.org" , "mingo@redhat.com" , "linux-kernel@vger.kernel.org" , "bp@alien8.de" , "acme@kernel.org" , "eranian@google.com" , "jolsa@kernel.org" , "ak@linux.intel.com" Subject: RE: [PATCH V4 1/2] x86/msr: expose msr_flip_bit function Thread-Topic: [PATCH V4 1/2] x86/msr: expose msr_flip_bit function Thread-Index: AQHSqDCrs6gSdx4VP02NKhEhSeGf3KGqyWYAgAD9/uA= Date: Wed, 29 Mar 2017 13:01:29 +0000 Message-ID: <37D7C6CF3E00A74B8858931C1DB2F077536C79E0@SHSMSX103.ccr.corp.intel.com> References: <1490751920-44720-1-git-send-email-kan.liang@intel.com> <1490751920-44720-2-git-send-email-kan.liang@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTFmY2QyZmUtZTBmZS00MzAzLTlkOTUtNDI5MTYyZDU4NjhkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlhucWRrbkY4YWJYRVwvblhCb2NYSTdrcWhJZk5pNW02SmNRRGJpNHJYMnJzPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v2TD35DU011876 Content-Length: 547 Lines: 23 > > -static inline int __flip_bit(u32 msr, u8 bit, bool set) > > +int msr_flip_bit(u32 msr, u8 bit, bool set) > > { > > struct msr m, m1; > > int err = -EINVAL; > > @@ -85,6 +85,7 @@ static inline int __flip_bit(u32 msr, u8 bit, bool > > set) > > > > return 1; > > } > > +EXPORT_SYMBOL_GPL(msr_flip_bit); > > That export is not required. The call site is always built in. > If so, msr_set_bit/msr_clear_bit should be enough for our requirement. msr_flip_bit is just a duplicate interface. I think I will drop this patch. Thanks, Kan