Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756094AbdC2NEx (ORCPT ); Wed, 29 Mar 2017 09:04:53 -0400 Received: from mail-it0-f53.google.com ([209.85.214.53]:35243 "EHLO mail-it0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755803AbdC2NEv (ORCPT ); Wed, 29 Mar 2017 09:04:51 -0400 MIME-Version: 1.0 In-Reply-To: References: <1490026491-21742-1-git-send-email-jacopo+renesas@jmondi.org> <1490026491-21742-3-git-send-email-jacopo+renesas@jmondi.org> <20170323160204.GL30223@w540> From: Linus Walleij Date: Wed, 29 Mar 2017 15:04:48 +0200 Message-ID: Subject: Re: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc To: Geert Uytterhoeven Cc: jacopo , Jacopo Mondi , Geert Uytterhoeven , Laurent Pinchart , Chris Brandt , Rob Herring , Mark Rutland , Russell King , Linux-Renesas , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 997 Lines: 29 On Wed, Mar 29, 2017 at 1:20 PM, Geert Uytterhoeven wrote: >> I do not understand the notion of "flags" here. I hope that is not referring > > Flags refers to BI_DIR, SWIO_IN, and SWIO_OUT, from > https://patchwork.kernel.org/patch/9643047/ Aha I will go in and review that closer because it doesn't seem right. Sorry for missing it. >> i2c1_pins_a: i2c1@0 { >> pins { >> pinmux = , >> ; > > If we follow this example, then we can list all combinations in > include/dt-bindings/pinctrl/r7s72100-pinctrl.h, instead of creating the value > by combining the bits using a macro where we need it in the DTS. > > It's gonna be a long list, though... Size is not the issue, readability is the issue. I don't see why you would need to list "all combinations" since the trees go through the C preprocessor so you can use macros and bit | OR to build them? Yours, Linus Walleij