Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756144AbdC2NFl (ORCPT ); Wed, 29 Mar 2017 09:05:41 -0400 Received: from mail-lf0-f54.google.com ([209.85.215.54]:36847 "EHLO mail-lf0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755921AbdC2NFk (ORCPT ); Wed, 29 Mar 2017 09:05:40 -0400 Subject: Re: [PATCH] PCI: generic: stop hiding pci_host_common_probe declaration To: Arnd Bergmann , Bjorn Helgaas References: <20170321160003.339217-1-arnd@arndb.de> Cc: Jayachandran C , Lorenzo Pieralisi , Dongdong Liu , Christopher Covington , Duc Dang , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org From: Tomasz Nowicki Message-ID: <28eaa9e9-9431-d924-c419-3e75df02fd6c@semihalf.com> Date: Wed, 29 Mar 2017 15:05:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170321160003.339217-1-arnd@arndb.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1484 Lines: 40 Hi Arnd, On 21.03.2017 16:59, Arnd Bergmann wrote: > When pci_host_common_probe() was moved into a separate module, the #ifdef around > the declaration was left in the header file, which can lead to build errors in > some configurations: > > drivers/pci/host/pci-thunder-pem.c: In function 'thunder_pem_probe': > drivers/pci/host/pci-thunder-pem.c:412:9: error: implicit declaration of function 'pci_host_common_probe';did you mean 'pci_host_bridge_priv'? [-Werror=implicit-function-declaration] > > The ifdef serves no real purpose anyway, so we can just remove it. > > Fixes: 4e64dbe226e7 ("PCI: generic: Expose pci_host_common_probe() for use by other drivers") > Signed-off-by: Arnd Bergmann > --- > include/linux/pci-ecam.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/include/linux/pci-ecam.h b/include/linux/pci-ecam.h > index f0d2b9451270..92a73847e1d3 100644 > --- a/include/linux/pci-ecam.h > +++ b/include/linux/pci-ecam.h > @@ -68,9 +68,7 @@ extern struct pci_ecam_ops xgene_v1_pcie_ecam_ops; /* APM X-Gene PCIe v1 */ > extern struct pci_ecam_ops xgene_v2_pcie_ecam_ops; /* APM X-Gene PCIe v2.x */ > #endif > > -#ifdef CONFIG_PCI_HOST_GENERIC > /* for DT-based PCI controllers that support ECAM */ > int pci_host_common_probe(struct platform_device *pdev, > struct pci_ecam_ops *ops); > #endif > -#endif > Thanks for fixing this. Reviewed-by: Tomasz Nowicki Tested-by: Tomasz Nowicki Tomasz