Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754593AbdC2N0V (ORCPT ); Wed, 29 Mar 2017 09:26:21 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:55487 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752410AbdC2N0S (ORCPT ); Wed, 29 Mar 2017 09:26:18 -0400 Date: Wed, 29 Mar 2017 15:26:11 +0200 From: jacopo To: Chris Brandt Cc: Jacopo Mondi , "geert+renesas@glider.be" , "laurent.pinchart@ideasonboard.com" , "linus.walleij@linaro.org" , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "linux@armlinux.org.uk" , "linux-renesas-soc@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3 4/7] arm: dts: r7s72100: Add pin controller node Message-ID: <20170329132611.GC6247@w540> References: <1490368934-12494-1-git-send-email-jacopo+renesas@jmondi.org> <1490368934-12494-5-git-send-email-jacopo+renesas@jmondi.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 705 Lines: 30 Hi Chris, On Mon, Mar 27, 2017 at 05:12:04PM +0000, Chris Brandt wrote: > Hi Jacopo, > > > On Friday, March 24, 2017, Jacopo Mondi > > + pinctrl: pinctrl@fcfe3000 { > > + compatible = "renesas,r7s72100-ports"; > > + > > + #pinctrl-cells = <1>; > > + > > + reg = <0xfcfe3000 0x42C0>; > > Out of curiosity, why did you change this from 0x4248 to 0x42C0? > > In your update for renesas,rza1-pinctrl.txt, for the 'Example', you changed it from 0x4248 to 0x4230 (which Geert pointed out makes more sense), but then in the actual DT file you changed it to 0x42C0. Typo? > Yes, type. Or inability to perform basic mathematical operations. Not sure yet. Thanks for spotting this :) j > > Chris >