DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 9BAD581253
Date: Wed, 29 Mar 2017 09:59:07 -0500
From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Zhou Chengming <zhouchengming1@huawei.com>
Cc: live-patching@vger.kernel.org, linux-kernel@vger.kernel.org,
        jeyu@redhat.com, jikos@kernel.org, mbenes@suse.cz, pmladek@suse.com,
        huawei.libin@huawei.com
Subject: Re: [PATCH v2] livepatch: Reduce the time of finding module symbols
Message-ID: <20170329145907.a2y7uvysxj52jix2@treble>
References: <1490706635-45752-1-git-send-email-zhouchengming1@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1490706635-45752-1-git-send-email-zhouchengming1@huawei.com>
User-Agent: Mutt/1.6.0.1 (2016-04-01)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1133
Lines: 33

On Tue, Mar 28, 2017 at 09:10:35PM +0800, Zhou Chengming wrote:
> It's reported that the time of insmoding a klp.ko for one of our
> out-tree modules is too long.
> 
> ~ time sudo insmod klp.ko
> real	0m23.799s
> user	0m0.036s
> sys	0m21.256s
> 
> Then we found the reason: our out-tree module used a lot of static local
> variables, so klp.ko has a lot of relocation records which reference the
> module. Then for each such entry klp_find_object_symbol() is called to
> resolve it, but this function uses the interface kallsyms_on_each_symbol()
> even for finding module symbols, so will waste a lot of time on walking
> through vmlinux kallsyms table many times.
> 
> This patch changes it to use module_kallsyms_on_each_symbol() for modules
> symbols. After we apply this patch, the sys time reduced dramatically.
> 
> ~ time sudo insmod klp.ko
> real	0m1.007s
> user	0m0.032s
> sys	0m0.924s
> 
> Signed-off-by: Zhou Chengming <zhouchengming1@huawei.com>

It would be good to make kallsyms faster, but either way this still a
performance improvement for patching modules.

Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>

-- 
Josh