Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932234AbdC2PSe (ORCPT ); Wed, 29 Mar 2017 11:18:34 -0400 Received: from relmlor4.renesas.com ([210.160.252.174]:10502 "EHLO relmlie3.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752373AbdC2PSb (ORCPT ); Wed, 29 Mar 2017 11:18:31 -0400 X-IronPort-AV: E=Sophos;i="5.36,241,1486393200"; d="scan'208";a="238129435" From: Chris Brandt To: Geert Uytterhoeven CC: Linus Walleij , Jacopo Mondi , Bjorn Andersson , Geert Uytterhoeven , Laurent Pinchart , Rob Herring , "Mark Rutland" , Russell King , Linux-Renesas , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH v3 3/7] arm: dts: dt-bindings: Add Renesas RZ pinctrl header Thread-Topic: [PATCH v3 3/7] arm: dts: dt-bindings: Add Renesas RZ pinctrl header Thread-Index: AQHSpLJ6VNE1pFUaX0a1Hx3QR4RDhaGr1ZuAgAAPSICAAAvTAIAAAkrw Date: Wed, 29 Mar 2017 15:18:21 +0000 Message-ID: References: <1490368934-12494-1-git-send-email-jacopo+renesas@jmondi.org> <1490368934-12494-4-git-send-email-jacopo+renesas@jmondi.org> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: linux-m68k.org; dkim=none (message not signed) header.d=none;linux-m68k.org; dmarc=none action=none header.from=renesas.com; x-originating-ip: [75.60.247.61] x-microsoft-exchange-diagnostics: 1;SG2PR06MB1168;7:Ty3e/KaBzxbhjAF041aLn6sQlNE0DVz7mzYeAKbjEdO51B9RU81bT8q/lmOAio65w6rHxXiehKoH4+VQK5KLKvoG9wU0/3ZJmacnnDSENaAVKzJWveNmcB1QnvsSjswL2h73dvB9I99ktYO3vBP/ogCQAppTXtw7IN3dXP7IB2AfGq/I2IEmGIuUL25HKMjiwQ/LOF4v08IvtXqxZC0HZMnwWmtNcriofYx1YIKqLoosmX5OuK8WJ1Sa9IS/9WgfJlugTEG4jH34Q43AH6vBl1hlU5CsioKHz1VDe/eWA4a+mfaKdelknilYbmISy12q+l9a6CwpMoKEbRzKIF6Lag==;20:fIQZIKt9z/EhiTPEgbaSWQtSzMTfqJ/8Sw2KTpNbn/QYkVWAa3PlWy3iKsiRN1eln85TnNVgWMov2SBmpCe4bB/6OG735zIiraW0nDVJEpwgid9eJfM0Wo+lVfF4TgTzNoVjQPcpwv1sLZoSCPllOgX73fL6wlAhXQ29EfTZMUM= x-ms-office365-filtering-correlation-id: 16af1c1c-6258-48a6-ea99-08d476b6d678 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081);SRVR:SG2PR06MB1168; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026)(6041248)(20161123555025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406075)(20161123558025)(20161123562025)(20161123560025)(6072148);SRVR:SG2PR06MB1168;BCL:0;PCL:0;RULEID:;SRVR:SG2PR06MB1168; x-forefront-prvs: 0261CCEEDF x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39840400002)(39450400003)(39410400002)(39860400002)(39850400002)(39400400002)(24454002)(6506006)(102836003)(6116002)(5660300001)(7416002)(77096006)(74316002)(7736002)(305945005)(122556002)(4326008)(6436002)(3660700001)(38730400002)(3280700002)(6246003)(54906002)(99286003)(9686003)(3846002)(55016002)(110136004)(25786009)(2906002)(53936002)(54356999)(81166006)(76176999)(189998001)(50986999)(8936002)(86362001)(2900100001)(8676002)(2950100002)(93886004)(33656002)(7696004)(229853002)(6916009)(66066001);DIR:OUT;SFP:1102;SCL:1;SRVR:SG2PR06MB1168;H:SG2PR06MB1165.apcprd06.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Mar 2017 15:18:21.8224 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB1168 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v2TFJ2Du025857 Content-Length: 2106 Lines: 70 Hi Geert, On Wednesday, March 29, 2017, Geert Uytterhoeven wrote: > > But, what do we do for Ethernet? All the pins are "normal" except just > > the MDIO pin needs to be bidirectional. > > That's the part I'm confused by. > > How do we flag that just the ET_MDIO needs "bidirectional"? > > You add subnodes, cfr. arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts: > > avb_pins: avb { > mux { > groups = "avb_link", "avb_phy_int", "avb_mdc", > "avb_mii"; > function = "avb"; > }; > > pins_mdc { > groups = "avb_mdc"; > drive-strength = <24>; > }; > > pins_mii_tx { > pins = "PIN_AVB_TX_CTL", "PIN_AVB_TXC", > "PIN_AVB_TD0", > "PIN_AVB_TD1", "PIN_AVB_TD2", > "PIN_AVB_TD3"; > drive-strength = <12>; > }; > }; Oh, so there is a way! Thank you. So, for clarity: /* Ethernet */ ether_pins: ether { /* Ethernet on Ports 1,2,3,5 */ mux { pins = , /* P1_14 = ET_COL */ , /* P5_9 = ET_MDC */ , /* P3_4 = ET_RXCLK */ , /* P3_5 = ET_RXER */ , /* P3_6 = ET_RXDV */ , /* P2_0 = ET_TXCLK */ , /* P2_1 = ET_TXER */ , /* P2_2 = ET_TXEN */ , /* P2_3 = ET_CRS */ , /* P2_4 = ET_TXD0 */ , /* P2_5 = ET_TXD1 */ , /* P2_6 = ET_TXD2 */ , /* P2_7 = ET_TXD3 */ , /* P2_8 = ET_RXD0 */ , /* P2_9 = ET_RXD1 */ , /* P2_10 = ET_RXD2 */ ; /* P2_11 = ET_RXD3 */ }; pins_bidir { pins = , /* P3_3 = ET_MDIO */ bidirectional; }; }; Chris