DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com A45AE65403
Date: Wed, 29 Mar 2017 19:04:42 +0200
From: Oleg Nesterov <oleg@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        Andy Lutomirski <luto@kernel.org>,
        Denys Vlasenko <dvlasenk@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
        Ingo Molnar <mingo@redhat.com>,
        Jan Kratochvil <jan.kratochvil@redhat.com>,
        Pedro Alves <palves@redhat.com>, Thomas Gleixner <tglx@linutronix.de>,
        the arch/x86 maintainers <x86@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: syscall_get_error() && TS_ checks
Message-ID: <20170329170442.GA24342@redhat.com>
References: <20170328145413.GA3164@redhat.com>
 <20170329163335.GA23977@redhat.com>
 <CA+55aFy1Dayhmw0r8syRPBJo+10EOfPmeCTTTxzcLiQRrG69jg@mail.gmail.com>
 <20170329165554.GA24250@redhat.com>
 <CA+55aFzbbLZaWvg+vTEKrfzZkwb=iAVUK5cZu2LxdbevZiGJ2g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CA+55aFzbbLZaWvg+vTEKrfzZkwb=iAVUK5cZu2LxdbevZiGJ2g@mail.gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 629
Lines: 16

On 03/29, Linus Torvalds wrote:
>
> On Wed, Mar 29, 2017 at 9:55 AM, Oleg Nesterov <oleg@redhat.com> wrote:
> >
> > Once again, it is only used in arch/x86/kernel/signal.c by do_signal() and
> > handle_signal(). We do not care if mmap() returns a valid pointer with the
> > high bit set, regs-ax can't be confused with -ERESTART code.
>
> Immaterial. If the function is called "get_error()", it sure as hell
> shouldn't return a random non-error value.

Oh, I agree, and let me repeat the 3rd time that I suggest to kill this
helper and use syscall_get_return_value() in arch/x86/kernel/signal.c,
it has no other callers.

Oleg.