MIME-Version: 1.0
In-Reply-To: <20170329170442.GA24342@redhat.com>
References: <20170328145413.GA3164@redhat.com> <20170329163335.GA23977@redhat.com>
 <CA+55aFy1Dayhmw0r8syRPBJo+10EOfPmeCTTTxzcLiQRrG69jg@mail.gmail.com>
 <20170329165554.GA24250@redhat.com> <CA+55aFzbbLZaWvg+vTEKrfzZkwb=iAVUK5cZu2LxdbevZiGJ2g@mail.gmail.com>
 <20170329170442.GA24342@redhat.com>
From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Wed, 29 Mar 2017 10:16:36 -0700
Message-ID: <CA+55aFx_K58D10-J81PgDZnNcZATMDVL2k_8WJjAfb_EFiAsKw@mail.gmail.com>
Subject: Re: syscall_get_error() && TS_ checks
To: Oleg Nesterov <oleg@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        Andy Lutomirski <luto@kernel.org>,
        Denys Vlasenko <dvlasenk@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
        Ingo Molnar <mingo@redhat.com>,
        Jan Kratochvil <jan.kratochvil@redhat.com>,
        Pedro Alves <palves@redhat.com>, Thomas Gleixner <tglx@linutronix.de>,
        "the arch/x86 maintainers" <x86@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 647
Lines: 17

On Wed, Mar 29, 2017 at 10:04 AM, Oleg Nesterov <oleg@redhat.com> wrote:
>
> Oh, I agree, and let me repeat the 3rd time that I suggest to kill this
> helper and use syscall_get_return_value() in arch/x86/kernel/signal.c,
> it has no other callers.

That is probably fine, I'm just arguing against the suggested changes
to syscall_get_error().

That said, I'm not sure why you want to change this in the first
place? I think the current syscall_get_error() - with explicit compat
handling and all - is fine.

But if the aim is to just remove syscall_get_error() entirely because
it's so unused, then I'm ok with that.

                      Linus