Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932851AbdC2T6r (ORCPT ); Wed, 29 Mar 2017 15:58:47 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:38303 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753515AbdC2T6H (ORCPT ); Wed, 29 Mar 2017 15:58:07 -0400 Date: Wed, 29 Mar 2017 12:58:04 -0700 From: Darren Hart To: =?utf-8?B?TWljaGHFgiBLxJlwaWXFhA==?= Cc: Jonathan Woithe , Andy Shevchenko , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/8] platform/x86: fujitsu-laptop: switch to a managed backlight input device Message-ID: <20170329195804.GD15472@localhost.localdomain> References: <20170320093224.18541-1-kernel@kempniu.pl> <20170320093224.18541-3-kernel@kempniu.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170320093224.18541-3-kernel@kempniu.pl> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 462 Lines: 14 On Mon, Mar 20, 2017 at 10:32:18AM +0100, Michał Kępień wrote: > Use a managed input device for brightness events in order to simplify > two error paths and one cleanup function while also reducing the number > of local variables required. Remove double assignment to make > checkpatch happy. > > Signed-off-by: Michał Kępień And this one mostly addresses my commentary on 1/8. -- Darren Hart VMware Open Source Technology Center