Subject: Re: [RFC PATCH 4/5] sched/events: Introduce sched_entity load
 tracking trace event
To: Peter Zijlstra <peterz@infradead.org>
References: <20170328063541.12912-1-dietmar.eggemann@arm.com>
 <20170328063541.12912-5-dietmar.eggemann@arm.com>
 <20170328080824.uujenx4e6n5kwk5d@hirez.programming.kicks-ass.net>
 <4162eba0-47f0-f695-42e9-66655b11a50a@arm.com>
 <20170328164110.gcejuwpelhhiblpv@hirez.programming.kicks-ass.net>
Cc: Ingo Molnar <mingo@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
        Matt Fleming <matt@codeblueprint.co.uk>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Morten Rasmussen <morten.rasmussen@arm.com>,
        Juri Lelli <juri.lelli@arm.com>,
        Patrick Bellasi <patrick.bellasi@arm.com>
From: Dietmar Eggemann <dietmar.eggemann@arm.com>
Message-ID: <28a1712d-a60d-3870-0c2b-2ebe55c9e61b@arm.com>
Date: Wed, 29 Mar 2017 22:19:30 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <20170328164110.gcejuwpelhhiblpv@hirez.programming.kicks-ass.net>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 436
Lines: 11

On 03/28/2017 06:41 PM, Peter Zijlstra wrote:
> On Tue, Mar 28, 2017 at 04:13:45PM +0200, Dietmar Eggemann wrote:
>
>> Do you think that making them public in include/linux/sched.h is the way to
>> go?
>
> No; all that stuff should really stay private. tracepoints are a very
> bad reason to leak this stuff.

Understood & makes sense to me. In hindsight, it's not too complicated 
to code group_cfs_rq in include/trace/events/sched.h.