Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932829AbdC2VCA (ORCPT ); Wed, 29 Mar 2017 17:02:00 -0400 Received: from mx2.suse.de ([195.135.220.15]:50145 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932738AbdC2VBS (ORCPT ); Wed, 29 Mar 2017 17:01:18 -0400 Date: Wed, 29 Mar 2017 23:01:43 +0200 From: Joerg Roedel To: Jacob Pan Cc: Joerg Roedel , iommu@lists.linux-foundation.org, David Woodhouse , linux-kernel@vger.kernel.org Subject: Re: [PATCH] iommu/vt-d: Make sure IOMMUs are off when intel_iommu=off Message-ID: <20170329210143.GV8329@suse.de> References: <1490799639-15965-1-git-send-email-joro@8bytes.org> <20170329085153.5d215d44@jacob-builder> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170329085153.5d215d44@jacob-builder> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 686 Lines: 21 On Wed, Mar 29, 2017 at 08:51:53AM -0700, Jacob Pan wrote: > On Wed, 29 Mar 2017 17:00:39 +0200 > Joerg Roedel wrote: > > +static void intel_disable_iommus(void) > > +{ > > + struct intel_iommu *iommu = NULL; > > + struct dmar_drhd_unit *drhd; > > + > > + for_each_iommu(iommu, drhd) > > + iommu_disable_translation(iommu); > should we also disable IR here? i.e. > iommu_disable_irq_remapping(iommu); No, irq remapping depends on another parameter (intremap=off) and needs to be handled seperatly. I already looked at it and this needs to be part of a larger effort as it required changes in code-paths that are shared between Intel and AMD IOMMU drivers. Joerg