Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933030AbdC2VHE (ORCPT ); Wed, 29 Mar 2017 17:07:04 -0400 Received: from mail-vk0-f44.google.com ([209.85.213.44]:33479 "EHLO mail-vk0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932708AbdC2VGW (ORCPT ); Wed, 29 Mar 2017 17:06:22 -0400 MIME-Version: 1.0 In-Reply-To: <20170329202026.4t5va6plsepdefpf@pd.tnic> References: <20170329202026.4t5va6plsepdefpf@pd.tnic> From: Andy Lutomirski Date: Wed, 29 Mar 2017 14:05:59 -0700 Message-ID: Subject: Re: [PATCH v2 1/2] x86/boot/32: Delete cpuinfo_x86::wp_works_ok To: Borislav Petkov Cc: Andy Lutomirski , X86 ML , "linux-kernel@vger.kernel.org" , Boris Ostrovsky , Juergen Gross , Thomas Garnier Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1034 Lines: 31 On Wed, Mar 29, 2017 at 1:20 PM, Borislav Petkov wrote: > On Wed, Mar 29, 2017 at 09:48:41AM -0700, Andy Lutomirski wrote: >> Linux refuses to boot if WP doesn't work okay, so tracking whether >> it works serves no purpose. The only use I can see at all for wp_works_ok >> is that it lets Xen bypass test_wp_bit(). If this is truly needed, >> it could be more cleanly handled using X86_FEATURE_XENPV, but it >> looks like Xen can handle test_wp_bit() correctly without special >> cases at all. >> >> Signed-off-by: Andy Lutomirski > > https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?id=6415813bae75feba10b8ca3ed6634a72c2a4d313 > > What's up? > Wow, I based on tip/x86/mm per Ingo's request, but maybe that was the wrong branch, and apparently Mathias did the same thing in the mean time. Whoops. I'll rebase again. > -- > Regards/Gruss, > Boris. > > Good mailing practices for 400: avoid top-posting and trim the reply. -- Andy Lutomirski AMA Capital Management, LLC