Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933166AbdC2V3p (ORCPT ); Wed, 29 Mar 2017 17:29:45 -0400 Received: from mail-vk0-f66.google.com ([209.85.213.66]:35922 "EHLO mail-vk0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932663AbdC2V2H (ORCPT ); Wed, 29 Mar 2017 17:28:07 -0400 MIME-Version: 1.0 In-Reply-To: References: <20170328202147.GA21830@singhal-Inspiron-5558> From: SIMRAN SINGHAL Date: Thu, 30 Mar 2017 02:58:05 +0530 Message-ID: Subject: Re: [PATCH] iio: dac: ad5504: constify attribute_group structures To: Jonathan Cameron Cc: Lars-Peter Clausen , Michael Hennerich , Hartmut Knaack , Peter Meerwald-Stadler , linux-iio@vger.kernel.org, Linux Kernel Mailing List , outreachy-kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2042 Lines: 75 On Thu, Mar 30, 2017 at 2:39 AM, Jonathan Cameron wrote: > On 28/03/17 21:21, simran singhal wrote: >> Check for attribute_group structures that are only stored in the >> event_attrs filed of iio_info structure. As the event_attrs field of >> iio_info structures is constant, so these attribute_group structures can >> also be declared constant. Done using coccinelle: >> >> @r1 disable optional_qualifier @ >> identifier i; >> position p; >> @@ >> static struct attribute_group i@p = {...}; >> >> @ok1@ >> identifier r1.i; >> position p; >> struct iio_info x; >> @@ >> x.event_attrs=&i@p; >> >> @bad@ >> position p!={r1.p,ok1.p}; >> identifier r1.i; >> @@ >> i@p >> >> @depends on !bad disable optional_qualifier@ >> identifier r1.i; >> @@ >> static >> +const >> struct attribute_group i={...}; >> >> @depends on !bad disable optional_qualifier@ >> identifier r1.i; >> @@ >> +const >> struct attribute_group i; >> >> File size before: >> text data bss dec hex filename >> 3046 360 0 3406 d4e drivers/iio/dac/ad5504.o >> >> File size after: >> text data bss dec hex filename >> 3110 296 0 3406 d4e drivers/iio/dac/ad5504.o >> >> Signed-off-by: simran singhal > Applied to the togreg branch of iio.git and pushed out as testing > for the autobuilders to play with it. > But my tree is up-to-date and I also test it before sending. > Thanks, > > Jonathan >> --- >> drivers/iio/dac/ad5504.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/iio/dac/ad5504.c b/drivers/iio/dac/ad5504.c >> index 788b3d6..22a027d 100644 >> --- a/drivers/iio/dac/ad5504.c >> +++ b/drivers/iio/dac/ad5504.c >> @@ -212,7 +212,7 @@ static struct attribute *ad5504_ev_attributes[] = { >> NULL, >> }; >> >> -static struct attribute_group ad5504_ev_attribute_group = { >> +static const struct attribute_group ad5504_ev_attribute_group = { >> .attrs = ad5504_ev_attributes, >> }; >> >> >