Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933020AbdC2XIM (ORCPT ); Wed, 29 Mar 2017 19:08:12 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:56789 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932679AbdC2XIK (ORCPT ); Wed, 29 Mar 2017 19:08:10 -0400 Subject: Re: [PATCH] crypto: vmx: Remove dubiously licensed crypto code To: =?UTF-8?Q?Michal_Such=c3=a1nek?= , Greg Kroah-Hartman References: <20170329125639.14288-1-msuchanek@suse.de> <20170329145135.GA28057@kroah.com> <20170329171327.38d4fdd6@kitsune.suse.cz> Cc: "Leonidas S. Barbosa" , Herbert Xu , Geert Uytterhoeven , linux-kernel@vger.kernel.org, Paul Mackerras , linux-crypto@vger.kernel.org, Paulo Flabiano Smorigo , Mauro Carvalho Chehab , linuxppc-dev@lists.ozlabs.org, "David S. Miller" From: Tyrel Datwyler Date: Wed, 29 Mar 2017 16:08:01 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170329171327.38d4fdd6@kitsune.suse.cz> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 17032923-0052-0000-0000-000001BE9D9C X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00006873; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000206; SDB=6.00840520; UDB=6.00413701; IPR=6.00618514; BA=6.00005248; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00014857; XFM=3.00000013; UTC=2017-03-29 23:08:07 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17032923-0053-0000-0000-00004F88D453 Message-Id: <7ec54553-610c-a5dc-d4d9-3c83f6a161d9@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-03-29_18:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1703290192 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2179 Lines: 52 On 03/29/2017 08:13 AM, Michal Such?nek wrote: > On Wed, 29 Mar 2017 16:51:35 +0200 > Greg Kroah-Hartman wrote: > >> On Wed, Mar 29, 2017 at 02:56:39PM +0200, Michal Suchanek wrote: >>> While reviewing commit 11c6e16ee13a ("crypto: vmx - Adding asm >>> subroutines for XTS") which adds the OpenSSL license header to >>> drivers/crypto/vmx/aesp8-ppc.pl licensing of this driver came into >>> qestion. The whole license reads: >>> >>> # Licensed under the OpenSSL license (the "License"). You may not >>> use # this file except in compliance with the License. You can >>> obtain a # copy >>> # in the file LICENSE in the source distribution or at >>> # https://www.openssl.org/source/license.html >>> >>> # >>> # >>> ==================================================================== >>> # Written by Andy Polyakov for the OpenSSL # >>> project. The module is, however, dual licensed under OpenSSL and # >>> CRYPTOGAMS licenses depending on where you obtain it. For further # >>> details see http://www.openssl.org/~appro/cryptogams/. # >>> ==================================================================== >>> >>> After seeking legal advice it is still not clear that this driver >>> can be legally used in Linux. In particular the "depending on where >>> you obtain it" part does not make it clear when you can apply the >>> GPL and when the OpenSSL license. >>> >>> I tried contacting the author of the code for clarification but did >>> not hear back. In absence of clear licensing the only solution I >>> see is removing this code. A quick 'git grep OpenSSL' of the Linux tree returns several other crypto files under the ARM architecture that are similarly licensed. Namely: arch/arm/crypto/sha1-armv4-large.S arch/arm/crypto/sha256-armv4.pl arch/arm/crypto/sha256-core.S_shipped arch/arm/crypto/sha512-armv4.pl arch/arm/crypto/sha512-core.S_shipped arch/arm64/crypto/sha256-core.S_shipped arch/arm64/crypto/sha512-armv8.pl arch/arm64/crypto/sha512-core.S_shipped On closer inspection of some of those files have the addendum that "Permission to use under GPL terms is granted", but not all of them. -Tyrel