Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753303AbdC3Bwv (ORCPT ); Wed, 29 Mar 2017 21:52:51 -0400 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:44876 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751468AbdC3Bws (ORCPT ); Wed, 29 Mar 2017 21:52:48 -0400 Subject: Re: [PATCH] Add checks for kmalloc allocation failures To: Eric Dumazet , Colin King References: <20170329155447.17991-1-colin.king@canonical.com> <1490804511.24891.37.camel@edumazet-glaptop3.roam.corp.google.com> Cc: Harry Morris , linuxdev@cascoda.com, Alexander Aring , linux-wpan@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org From: Stefan Schmidt Message-ID: Date: Thu, 30 Mar 2017 03:52:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1490804511.24891.37.camel@edumazet-glaptop3.roam.corp.google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 818 Lines: 25 Hello. On 03/29/2017 06:21 PM, Eric Dumazet wrote: > On Wed, 2017-03-29 at 16:54 +0100, Colin King wrote: >> From: Colin Ian King >> >> Ensure we don't end up with a null pointer dereferences by checking >> for for allocation failures. Allocate by sizeof(*ptr) rather than >> the type to fix checkpack warnings. Also merge multiple lines into >> one line for the kmalloc call. >> >> Detected by CoverityScan, CID#1422435 ("Dereference null return value") > > OK, but could you change patch title to be less generic ? > > Also, what tree is this patch targeting ? > > # ls -l drivers/net/ieee802154/ca8210.c > ls: cannot access drivers/net/ieee802154/ca8210.c: No such file or > directory This new driver is sitting in bluetooth-next right now for the next merge. regards Stefan Schmidt