Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S264652AbTE1LBQ (ORCPT ); Wed, 28 May 2003 07:01:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264671AbTE1LBP (ORCPT ); Wed, 28 May 2003 07:01:15 -0400 Received: from smtp-out2.iol.cz ([194.228.2.87]:35209 "EHLO smtp-out2.iol.cz") by vger.kernel.org with ESMTP id S264652AbTE1LBG (ORCPT ); Wed, 28 May 2003 07:01:06 -0400 Date: Wed, 28 May 2003 13:14:01 +0200 From: Pavel Machek To: Milton Miller Cc: Pavel Machek , linux-kernel@vger.kernel.org, Andrew Morton Subject: Re: [PATCH] fix oops on resume from apm bios initiated suspend Message-ID: <20030528111401.GB342@elf.ucw.cz> References: <200305280643.h4S6hRQF028038@sullivan.realtime.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200305280643.h4S6hRQF028038@sullivan.realtime.net> X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.3i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1403 Lines: 39 Hi! > Didn't know if you caught this one, but it fixes it for me and others > who responded on the list. > > mm is NULL for kernel threads without their own context. active_mm is > maintained the one we lazly switch from. > > Without this patch, apm bios initiated suspend events (eg panel close) > cause an oops on resume in the LDT restore, killing kapmd, which causes > further events to not be polled. Ouch, okay, this looks good. Andrew please apply. [I guess this is trivial enough for trivial patch monkey if andrew does not want to take it...] Pavel > ===== arch/i386/kernel/suspend.c 1.16 vs edited ===== > --- 1.16/arch/i386/kernel/suspend.c Sat May 17 16:09:37 2003 > +++ edited/arch/i386/kernel/suspend.c Sat May 24 05:00:02 2003 > @@ -114,7 +114,7 @@ > cpu_gdt_table[cpu][GDT_ENTRY_TSS].b &= 0xfffffdff; > > load_TR_desc(); /* This does ltr */ > - load_LDT(¤t->mm->context); /* This does lldt */ > + load_LDT(¤t->active_mm->context); /* This does lldt */ > > /* > * Now maybe reload the debug registers -- When do you have a heart between your knees? [Johanka's followup: and *two* hearts?] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/