Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754495AbdC3C4L (ORCPT ); Wed, 29 Mar 2017 22:56:11 -0400 Received: from mail-oi0-f43.google.com ([209.85.218.43]:34842 "EHLO mail-oi0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753915AbdC3C4J (ORCPT ); Wed, 29 Mar 2017 22:56:09 -0400 MIME-Version: 1.0 In-Reply-To: <8737dxh63n.fsf@linux.intel.com> References: <0b16763df04e197fb5b3c21b19799280d3bce275.1490248054.git.baolin.wang@linaro.org> <8737dxh63n.fsf@linux.intel.com> From: Baolin Wang Date: Thu, 30 Mar 2017 10:56:07 +0800 Message-ID: Subject: Re: [PATCH v2 1/2] usb: phy: Introduce one extcon device into usb phy To: Felipe Balbi Cc: Greg KH , USB , LKML , Linaro Kernel Mailman List , NeilBrown , Jun Li , Peter Chen , Mark Brown Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 847 Lines: 25 Hi, On 28 March 2017 at 21:40, Felipe Balbi wrote: > > Hi, > > Baolin Wang writes: >> Usually usb phy need register one extcon device to get the connection >> notifications. It will remove some duplicate code if the extcon device >> is registered using common code instead of each phy driver having its >> own related extcon APIs. So we add one pointer of extcon device into >> usb phy structure, and some other helper functions to register extcon. >> >> Suggested-by: NeilBrown >> Signed-off-by: Baolin Wang > > will this work with devices which have ID and VBUS from separate EXTCON > devices? Ah, It can not work for separate EXTCON devices, now I realized some devices have separate EXTCON devices. Thanks for pointing this. -- Baolin.wang Best Regards