Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754672AbdC3DY5 (ORCPT ); Wed, 29 Mar 2017 23:24:57 -0400 Received: from mail.kernel.org ([198.145.29.136]:51266 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754495AbdC3DY4 (ORCPT ); Wed, 29 Mar 2017 23:24:56 -0400 From: "Luis R. Rodriguez" To: gregkh@linuxfoundation.org Cc: wagi@monom.org, dwmw2@infradead.org, rafal@milecki.pl, arend.vanspriel@broadcom.com, rjw@rjwysocki.net, yi1.li@linux.intel.com, atull@opensource.altera.com, moritz.fischer@ettus.com, pmladek@suse.com, johannes.berg@intel.com, emmanuel.grumbach@intel.com, luciano.coelho@intel.com, kvalo@codeaurora.org, luto@kernel.org, takahiro.akashi@linaro.org, dhowells@redhat.com, pjones@redhat.com, linux-kernel@vger.kernel.org, "Luis R. Rodriguez" Subject: [PATCH 0/5] firmware: move UMH locks onto fallback code Date: Wed, 29 Mar 2017 20:24:45 -0700 Message-Id: <20170330032450.17121-1-mcgrof@kernel.org> X-Mailer: git-send-email 2.11.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1294 Lines: 29 Greg, One of the eyesores on the old API was the use of the UMH lock even when we don't use any of the usermode helpers. It took quite a bit of git archeology to draw up a solution which makes me feel comfortable in moving this code out of the way given it may have added new protections we never knew about. A resolution is to make similar protections for direct FS lookups for now, and later after a release or so we can consider removing them. There is further possible work to do to clean up the UMH pollution on external code, but this can be done separately and is more a generic kernel/kmod.c thing than firmware thing. This changes makes subsequent patches able to fold the new driver data API onto the older firmware API. These all go hammered with 0-day and the firmware test scripts shipped upstream. Luis R. Rodriguez (5): firmware: share fw fallback killing on reboot/suspend firmware: always enable the reboot notifier firmware: add sanity check on shutdown/suspend firmware: move assign_firmware_buf() further up firmware: move umh try locks into the umh code .../driver-api/firmware/request_firmware.rst | 11 + drivers/base/firmware_class.c | 293 ++++++++++++++------- 2 files changed, 207 insertions(+), 97 deletions(-) -- 2.11.0