Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755567AbdC3D0q (ORCPT ); Wed, 29 Mar 2017 23:26:46 -0400 Received: from mail-oi0-f46.google.com ([209.85.218.46]:36267 "EHLO mail-oi0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755508AbdC3D0b (ORCPT ); Wed, 29 Mar 2017 23:26:31 -0400 MIME-Version: 1.0 In-Reply-To: <87zig5frgo.fsf@linux.intel.com> References: <0b16763df04e197fb5b3c21b19799280d3bce275.1490248054.git.baolin.wang@linaro.org> <87zig5frgo.fsf@linux.intel.com> From: Baolin Wang Date: Thu, 30 Mar 2017 11:26:29 +0800 Message-ID: Subject: Re: [PATCH v2 2/2] usb: phy: phy-qcom-8x16-usb: Remove redundant extcon register/unregister To: Felipe Balbi Cc: Greg KH , USB , LKML , Linaro Kernel Mailman List , NeilBrown , Jun Li , Peter Chen , Mark Brown Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 981 Lines: 27 Hi, On 28 March 2017 at 21:42, Felipe Balbi wrote: > > Hi, > > Baolin Wang writes: >> Since usb phy core has added common code to register or unregister >> extcon device, then phy-qcom-8x16-usb driver does not need its own >> code to register/unregister extcon device, then remove them. >> >> Signed-off-by: Baolin Wang > > so previous patch helped *ONE* single user? Was it really beneficial if > it's all for a single user? Which duplicated code did it remove? Now only 3 USB phy drivers (phy-qcom-8x16-usb.c, phy-omap-otg.c and phy-msm-usb.c) had registered an extcon, mostly did not. phy-omap-otg.c did not add one usb phy, so I did not convert it. phy-msm-usb.c had 2 separate extcon devices, but my last patch did not support separate extcon devices which need to modify again. Moreover in future usb phy drivers do not need to implement extcon things in their own drivers. -- Baolin.wang Best Regards