Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932348AbdC3D2h (ORCPT ); Wed, 29 Mar 2017 23:28:37 -0400 Received: from lelnx194.ext.ti.com ([198.47.27.80]:34082 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754740AbdC3D2f (ORCPT ); Wed, 29 Mar 2017 23:28:35 -0400 Subject: Re: [PATCH v2 3/8] ARM: OMAP5: Thermal: Add slope and offset values To: Eduardo Valentin References: <1489046762-11288-1-git-send-email-j-keerthy@ti.com> <1489046762-11288-4-git-send-email-j-keerthy@ti.com> <20170329043302.GA1596@localhost.localdomain> CC: , , , , , , , From: Keerthy Message-ID: Date: Thu, 30 Mar 2017 08:57:59 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170329043302.GA1596@localhost.localdomain> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1562 Lines: 62 On Wednesday 29 March 2017 10:03 AM, Eduardo Valentin wrote: > On Thu, Mar 09, 2017 at 01:35:57PM +0530, Keerthy wrote: >> Currently the slope and offset values for calculating the >> hot spot temperature of a particular thermal zone is part >> of driver data. Pass them here instead and obtain the values >> while of node parsing. > > > The patch is fine.. but > >> >> Signed-off-by: Keerthy >> --- >> arch/arm/boot/dts/omap5.dtsi | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi >> index 222155c..eaff2a5 100644 >> --- a/arch/arm/boot/dts/omap5.dtsi >> +++ b/arch/arm/boot/dts/omap5.dtsi >> @@ -1127,6 +1127,15 @@ >> >> &cpu_thermal { >> polling-delay = <500>; /* milliseconds */ >> + coefficients = <65 (-1791)>; > > I suppose you tried this change with this patch: > https://patchwork.kernel.org/patch/9619577/ > ? > > Otherwise, I do not see how your coeff would work, right? IIRC i did not have that patch. But No issues there. I did try deliberately with negative values and i retrieved the negative values in driver nicely. Fox ex: -20 unsigned when retrieved in driver as an int coeff will give me -20. I checked with multiple negative co-efficients and i retrieved the passed negative co-efficients in driver from DT. Regards, Keerthy > >> }; >> >> /include/ "omap54xx-clocks.dtsi" >> + >> +&gpu_thermal { >> + coefficients = <117 (-2992)>; >> +}; >> + >> +&core_thermal { >> + coefficients = <0 2000>; >> +}; >> -- >> 1.9.1 >>