Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932595AbdC3DaH (ORCPT ); Wed, 29 Mar 2017 23:30:07 -0400 Received: from lelnx193.ext.ti.com ([198.47.27.77]:18788 "EHLO lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932345AbdC3DaF (ORCPT ); Wed, 29 Mar 2017 23:30:05 -0400 Subject: Re: [PATCH v2 0/8] thermal: ti-soc-thermal: Migrate slope/offset data to device tree To: Eduardo Valentin , Tony Lindgren References: <1489046762-11288-1-git-send-email-j-keerthy@ti.com> <64ab8413-6cf1-864f-0550-9c8db59523f7@ti.com> <20170323205256.GO10760@atomide.com> <20170324142610.GX10760@atomide.com> <20170329043753.GB1596@localhost.localdomain> CC: , , , , , , From: Keerthy Message-ID: <5380b1bc-f3c6-a0ef-e458-7509d95d631e@ti.com> Date: Thu, 30 Mar 2017 08:59:31 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170329043753.GB1596@localhost.localdomain> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1562 Lines: 56 On Wednesday 29 March 2017 10:07 AM, Eduardo Valentin wrote: > Keerthy, > > On Fri, Mar 24, 2017 at 07:26:10AM -0700, Tony Lindgren wrote: >> * Keerthy [170323 20:29]: >>> >>> >>> On Friday 24 March 2017 02:22 AM, Tony Lindgren wrote: >>>> * Keerthy [170321 20:45]: >>>>> >>>>> >>>>> On Thursday 09 March 2017 01:35 PM, Keerthy wrote: >>>>>> Currently the slope and offset values for calculating the >>>>>> hot spot temperature of a particular thermal zone is part >>>>>> of driver data. Pass them here instead and obtain the values >>>>>> while of node parsing. >>>>>> >>>>>> Tested for the slope and constant values on DRA7-EVM, OMAP3-BEAGLE. > > Have you tried on boards that need negative coefficients? > > https://patchwork.kernel.org/patch/9619577/ Yes. I retrieved the negative values nicely in the driver passed via Device Tree. > >>>>> >>>>> Hi Eduardo, >>>>> >>>>> If the series looks okay could you please pull this? >>>> >>>> Also.. Are the dts changes safe for me to pick separately? >>> >>> Yes Tony they are safe to pulled separately. >> >> OK applying patches 1 - 5 of this series into omap-for-v4.12/dt-v2. > > Keerthy, > > The only thing I want you to confirm is if you are really getting the > negative coefficients, because currently of-thermal reads the array > using an OF helper that understands only unsigned. For this reason, I > will be queueing your patches only for next merge window, not as a fix, > not for rc's. I am getting negative co-efficients. > > >> >> Thanks, >> >> Tony