Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754735AbdC3DyS (ORCPT ); Wed, 29 Mar 2017 23:54:18 -0400 Received: from mout.gmx.net ([212.227.15.18]:57612 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752220AbdC3DyQ (ORCPT ); Wed, 29 Mar 2017 23:54:16 -0400 Message-ID: <1490846046.4167.37.camel@gmx.de> Subject: Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") From: Mike Galbraith To: "Michael S. Tsirkin" Cc: Christoph Hellwig , Thorsten Leemhuis , virtio-dev@lists.oasis-open.org, Linux Kernel Mailing List , rjones@redhat.com Date: Thu, 30 Mar 2017 05:54:06 +0200 In-Reply-To: <20170329231738-mutt-send-email-mst@kernel.org> References: <20170323145622.GA31690@lst.de> <1490605644.14634.50.camel@gmx.de> <20170327170540.GA28715@lst.de> <1490638711.26533.44.camel@gmx.de> <1490768602.5950.25.camel@gmx.de> <20170329231738-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:oZZJLUi1GyWpr4ABDqm6RbDHFrCGwPcOuPt5taWkUXkyz7/iuMG hVxjuZj4cEL+Oojzv5yMjcA9LroqvG7nubHnMg6+LnM9+H9FvxUzIFnvjvpuqfv7b7ZHfKA 3mLpmU8TXOI46QE3CW6QTzc9MXu86iGkMpJPMAbJ3KxNJrfsAFNIaDG09wIzOfn/TlTOO+u Q0jj4VPtbtLOB6FGTAACA== X-UI-Out-Filterresults: notjunk:1;V01:K0:EUug+yk484k=:mEi+7KF4a87gx8UQJk4oDr Y3lPtcvY5MN16+v9rLup8u7vt1nC/HrXIMBK7H3r7uJnV9qc0oMWgLYM+HsOIs0RzZ1susKbE hT0Po0GsM7PsX97trRrVleytUpx0Wb7vb3Clb6KzXDdApKzD4cXiV3rVp2lA+t/kXGTrfZN8h tO02Pswjowff4JWjyN6WETCpUw+nzq6zDp/OYUBPQUUPOQZhGSmom9NlIXfnj+a8qSFAon0oP D6Ez9xx4taGVQqO4HB7yPCdsYRN40zgOeCeQfzFQpzx8K8T1VO4ymk1ArhyPlQhFWchMOQ/Mq 4E2OTi4JAIh6buqpkhxtll+OwudHmGAHtSryGM1riNfWJGmG8COuRZWfsyvMxhOvZsUYYh3+O Uso72D+7IQ9s7IWLeoo8/rqTbqFGgUcQJu9xYBFuutAbpEWwxzrbCiDfBixDP/40kOACMCTQv 9prHQJ7EXS1IzsoMrHIaRe952GjXCTTcAo9UpWyBQ+hK583BvhIXeCokY1K4WyzhER5RImoD/ Pq5LfrrCr5ubzqvOITu7wh8GIIhGX+O70ATGLtxVYev92sXvI0mmmgMUznCORJIHAx7nCJwCU 9ohbEVcFYVcnoEbm2etheBW626F6gA9EvPUQbaGzoIjDO1c1/eSeCxlvMciaMLJx32QEws045 wpc8WJKdZFtzINAKrKifL7Hjwz1VHp8t6jAJaZsNpN26z3AiBUfOZy2JkbKm5+ErmiFWNAey1 2I5wpmk9tINTX67sQgPLgGrrtumoiqAxQIUsVohGUZPN4VgiRkHPaT8RA3xMXKZOdaDPKlTh2 QE+6PNx Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 650 Lines: 20 On Wed, 2017-03-29 at 23:19 +0300, Michael S. Tsirkin wrote: > > > > > > > > > > > &portdev->max_nr_ports) == 0) { > > @@ -2179,7 +2179,9 @@ static struct virtio_device_id id_table[ > > > > static unsigned int features[] = { > > > > > > VIRTIO_CONSOLE_F_SIZE, > > +#ifndef CONFIG_IRQ_FORCED_THREADING > > > > > > VIRTIO_CONSOLE_F_MULTIPORT, > > +#endif > > }; > > These look kind of questionable. > Is this part needed? I would have sworn it was, but double checking, nope, it's not. Hm, so I could make a prettier bandaid with a runtime check.. but it'd remain a bandaid, so I'll go do some beans 'n' biscuits work instead. -Mike