Message-ID: <1490846046.4167.37.camel@gmx.de>
Subject: Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use
 shared interrupts for virtqueues")
From: Mike Galbraith <efault@gmx.de>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>,
        Thorsten Leemhuis <linux@leemhuis.info>,
        virtio-dev@lists.oasis-open.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        rjones@redhat.com
Date: Thu, 30 Mar 2017 05:54:06 +0200
In-Reply-To: <20170329231738-mutt-send-email-mst@kernel.org>
References: <f49abfcc-723e-fa91-bda0-198f4a0da0c0@leemhuis.info>
         <20170323145622.GA31690@lst.de> <1490605644.14634.50.camel@gmx.de>
         <20170327170540.GA28715@lst.de> <1490638711.26533.44.camel@gmx.de>
         <1490768602.5950.25.camel@gmx.de>
         <20170329231738-mutt-send-email-mst@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 650
Lines: 20

On Wed, 2017-03-29 at 23:19 +0300, Michael S. Tsirkin wrote:
>  > > 	> > 	> > 	> > 	> >  &portdev->max_nr_ports) == 0) {
> > @@ -2179,7 +2179,9 @@ static struct virtio_device_id id_table[
> >  
> >  static unsigned int features[] = {
> >  > > 	> > VIRTIO_CONSOLE_F_SIZE,
> > +#ifndef CONFIG_IRQ_FORCED_THREADING
> >  > > 	> > VIRTIO_CONSOLE_F_MULTIPORT,
> > +#endif
> >  };
> 
> These look kind of questionable.
> Is this part needed?

I would have sworn it was, but double checking, nope, it's not.

Hm, so I could make a prettier bandaid with a runtime check.. but it'd
remain a bandaid, so I'll go do some beans 'n' biscuits work instead.

	-Mike