Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753639AbdC3D50 (ORCPT ); Wed, 29 Mar 2017 23:57:26 -0400 Received: from server.atrad.com.au ([150.101.241.2]:57766 "EHLO server.atrad.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751717AbdC3D5Z (ORCPT ); Wed, 29 Mar 2017 23:57:25 -0400 Date: Thu, 30 Mar 2017 14:26:26 +1030 From: Jonathan Woithe To: Darren Hart Cc: Andy Shevchenko , Micha?? K??pie?? , Andy Shevchenko , Platform Driver , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 0/8] fujitsu-laptop: use sparse keymaps for input event handling Message-ID: <20170330035626.GK19787@marvin.atrad.com.au> References: <20170320093224.18541-1-kernel@kempniu.pl> <20170324104959.GA31520@marvin.atrad.com.au> <20170327235719.GE23486@marvin.atrad.com.au> <20170328061618.GA3694@ozzy.nask.waw.pl> <20170328230029.GA29146@marvin.atrad.com.au> <20170329071926.GA1070@ozzy.nask.waw.pl> <20170330033650.GF15472@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170330033650.GF15472@localhost.localdomain> User-Agent: Mutt/1.5.23 (2014-03-12) X-MIMEDefang-action: accept Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1443 Lines: 31 On Wed, Mar 29, 2017 at 08:36:50PM -0700, Darren Hart wrote: > On Wed, Mar 29, 2017 at 07:35:50PM +0300, Andy Shevchenko wrote: > > On Wed, Mar 29, 2017 at 10:19 AM, Micha?? K??pie?? wrote: > > > > > Darren, Andy, in light of the above I will be awaiting your review of > > > this series. I will submit v2 afterwards, with all remarks from both > > > you and Jonathan taken into account. > > > > Darren marked this series under his name to review, so, I let him to > > speak for us. > > The series looks good to me. Nice work Micha??. They are logically divided and > address issues in a procedural way (so I stopped commenting until I read the > full series through as a couple of times you addressed a concern from a move in > a cleanup to follow). > > I've applied the noted change to 7/8 and will run this through my tests, but > don't anticipate any problems. Jonathan, if you don't have any additional > concerns, let me know if I can add your Reviewed-by. With the noted change to 7/8 applied I'm happy with the resulting series. As you noted, there is still some scope for making things more consistent, especially with regard to error handling. However, that is really a separate task which can be addressed in a later series. This present series doesn't impact on this issue in any significant way so it makes sense that be applied. Reviewed-by: Jonathan Woithe Regards jonathan