Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932744AbdC3HHD (ORCPT <rfc822;w@1wt.eu>);
        Thu, 30 Mar 2017 03:07:03 -0400
Received: from mail-wr0-f194.google.com ([209.85.128.194]:33464 "EHLO
        mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932181AbdC3HHC (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 30 Mar 2017 03:07:02 -0400
Date: Thu, 30 Mar 2017 09:06:57 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Borislav Petkov <bp@alien8.de>, Andy Lutomirski <luto@kernel.org>,
        X86 ML <x86@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Juergen Gross <jgross@suse.com>, Thomas Garnier <thgarnie@google.com>
Subject: Re: [PATCH v2 1/2] x86/boot/32: Delete cpuinfo_x86::wp_works_ok
Message-ID: <20170330070657.GA5176@gmail.com>
References: <cover.1490806048.git.luto@kernel.org>
 <fc1fd315329d1774377fd8ba07d53d7caa6a659b.1490806048.git.luto@kernel.org>
 <20170329202026.4t5va6plsepdefpf@pd.tnic>
 <CALCETrWOr00ZQuM3XANmJXp-FnfXfu7ZV9vdU8F-04JOC7xAsQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CALCETrWOr00ZQuM3XANmJXp-FnfXfu7ZV9vdU8F-04JOC7xAsQ@mail.gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1148
Lines: 30


* Andy Lutomirski <luto@amacapital.net> wrote:

> On Wed, Mar 29, 2017 at 1:20 PM, Borislav Petkov <bp@alien8.de> wrote:
> > On Wed, Mar 29, 2017 at 09:48:41AM -0700, Andy Lutomirski wrote:
> >> Linux refuses to boot if WP doesn't work okay, so tracking whether
> >> it works serves no purpose.  The only use I can see at all for wp_works_ok
> >> is that it lets Xen bypass test_wp_bit().  If this is truly needed,
> >> it could be more cleanly handled using X86_FEATURE_XENPV, but it
> >> looks like Xen can handle test_wp_bit() correctly without special
> >> cases at all.
> >>
> >> Signed-off-by: Andy Lutomirski <luto@kernel.org>
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?id=6415813bae75feba10b8ca3ed6634a72c2a4d313
> >
> > What's up?
> >
> 
> Wow, I based on tip/x86/mm per Ingo's request, but maybe that was the
> wrong branch, and apparently Mathias did the same thing in the mean
> time.  Whoops.  I'll rebase again.

Oops, I didn't realize the duplication either. The splitting up of the patch that 
I requested made the merge easier I suspect - albeit that's an unintended side 
effect.

Thanks,

	Ingo