Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932920AbdC3HRw convert rfc822-to-8bit (ORCPT ); Thu, 30 Mar 2017 03:17:52 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:37368 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932084AbdC3HRu (ORCPT ); Thu, 30 Mar 2017 03:17:50 -0400 Date: Thu, 30 Mar 2017 09:17:31 +0200 From: Cornelia Huck To: "Michael S. Tsirkin" Cc: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, Heiko Carstens , John Fastabend , Sudeep Dutt , virtualization@lists.linux-foundation.org, Ashutosh Dixit , Martin Schwidefsky Subject: Re: [PATCH 2/6] virtio: add context flag to find vqs In-Reply-To: <1490820507-8005-3-git-send-email-mst@redhat.com> References: <1490820507-8005-1-git-send-email-mst@redhat.com> <1490820507-8005-3-git-send-email-mst@redhat.com> Organization: IBM Deutschland Research & Development GmbH Vorsitzende des Aufsichtsrats: Martina Koederitz =?UTF-8?B?R2VzY2jDpGZ0c2bDvGhydW5nOg==?= Dirk Wittkopp Sitz der Gesellschaft: =?UTF-8?B?QsO2Ymxpbmdlbg==?= Registergericht: Amtsgericht Stuttgart, HRB 243294 X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT X-TM-AS-GCONF: 00 x-cbid: 17033007-0008-0000-0000-000004143E86 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17033007-0009-0000-0000-00001D0A2545 Message-Id: <20170330091731.1b54a2e1.cornelia.huck@de.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-03-30_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1703300067 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1191 Lines: 27 On Wed, 29 Mar 2017 23:48:51 +0300 "Michael S. Tsirkin" wrote: > Allows maintaining extra context per vq. For ease of use, passing in > NULL is legal and disables the feature for all vqs. > > Signed-off-by: Michael S. Tsirkin > --- > drivers/misc/mic/vop/vop_main.c | 9 ++++++--- > drivers/s390/virtio/kvm_virtio.c | 6 ++++-- > drivers/s390/virtio/virtio_ccw.c | 7 ++++--- > drivers/virtio/virtio_mmio.c | 8 +++++--- > drivers/virtio/virtio_pci_common.c | 18 +++++++++++------- > drivers/virtio/virtio_pci_common.h | 4 +++- > drivers/virtio/virtio_pci_legacy.c | 4 +++- > drivers/virtio/virtio_pci_modern.c | 12 ++++++++---- > drivers/virtio/virtio_ring.c | 7 +++++-- > include/linux/virtio_config.h | 18 +++++++++++++++--- > include/linux/virtio_ring.h | 3 +++ > 11 files changed, 67 insertions(+), 29 deletions(-) This series really needs a cover letter, explaining the motivation for adding this context. >From what I understand, you want to track some length parameter in virtio-net. As you don't use indirect descriptors in that case, you want to use a context instead. Did I get this correctly?