Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932922AbdC3JHw (ORCPT ); Thu, 30 Mar 2017 05:07:52 -0400 Received: from mail-yb0-f173.google.com ([209.85.213.173]:33640 "EHLO mail-yb0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754242AbdC3JFa (ORCPT ); Thu, 30 Mar 2017 05:05:30 -0400 MIME-Version: 1.0 In-Reply-To: <20170330103032.35558cf3@bbrezillon> References: <1490689242-5097-1-git-send-email-boris.brezillon@free-electrons.com> <20170330103032.35558cf3@bbrezillon> From: Max Filippov Date: Thu, 30 Mar 2017 02:05:28 -0700 Message-ID: Subject: Re: [PATCH] xtensa: Fix mmap() support To: Boris Brezillon Cc: Christoph Hellwig , Chris Zankel , "linux-xtensa@linux-xtensa.org" , Maxime Ripard , Thomas Petazzoni , LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 369 Lines: 19 On Thu, Mar 30, 2017 at 1:30 AM, Boris Brezillon wrote: >> Could you please instead check if the dma_common_mmap works for you >> with the attached patch? > > I will. BTW, shouldn't it be > > if (off >= XCHAL_KSEG_SIZE) > > instead of > > if (off > XCHAL_KSEG_SIZE) > ? Oops. Yes, you're right. -- Thanks. -- Max