Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932919AbdC3JHK (ORCPT ); Thu, 30 Mar 2017 05:07:10 -0400 Received: from mail-oi0-f50.google.com ([209.85.218.50]:36708 "EHLO mail-oi0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932792AbdC3JHF (ORCPT ); Thu, 30 Mar 2017 05:07:05 -0400 MIME-Version: 1.0 In-Reply-To: <9c8a5e49-826c-88c3-5186-977f3ec9304c@nod.at> References: <1490864181-2192-1-git-send-email-richard@nod.at> <9c8a5e49-826c-88c3-5186-977f3ec9304c@nod.at> From: Amir Goldstein Date: Thu, 30 Mar 2017 12:07:03 +0300 Message-ID: Subject: Re: [PATCH] ubifs: Fix O_TMPFILE corner case in ubifs_link() To: Richard Weinberger Cc: linux-mtd@lists.infradead.org, linux-kernel , Adrian Hunter , Artem Bityutskiy , "stable [v4.9]" , Ralph Sennhauser Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 993 Lines: 29 On Thu, Mar 30, 2017 at 12:03 PM, Richard Weinberger wrote: > Amir, > > Am 30.03.2017 um 10:59 schrieb Amir Goldstein: >> On Thu, Mar 30, 2017 at 11:56 AM, Richard Weinberger wrote: >>> It is perfectly fine to link a tmpfile back using linkat(). >>> Since tmpfiles are created with a link count of 0 they appear >>> on the orphan list, upon re-linking the inode has to be removed >>> from the orphan list again. >>> >> >> Looks good. >> >>> Cc: >>> Cc: Ralph Sennhauser >>> Cc: Amir Goldstein > >> typo: missing closing > > > Whoops, copied one byte too few from Thunderbird. :D > Will fix before pushing. > It's worth mentioning the bug that Ralph reported. The fact that overlayfs mount in v4.11-rc causes corruption of ubifs is much more severe than what the current commit message implies (fix of a corner case). I would also add # v4.9 hint to stable tag, just to be nice ;-)