Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932945AbdC3JKA (ORCPT ); Thu, 30 Mar 2017 05:10:00 -0400 Received: from b.ns.miles-group.at ([95.130.255.144]:44724 "EHLO radon.swed.at" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932772AbdC3JJ6 (ORCPT ); Thu, 30 Mar 2017 05:09:58 -0400 Subject: Re: [PATCH] ubifs: Fix O_TMPFILE corner case in ubifs_link() To: Amir Goldstein References: <1490864181-2192-1-git-send-email-richard@nod.at> <9c8a5e49-826c-88c3-5186-977f3ec9304c@nod.at> Cc: linux-mtd@lists.infradead.org, linux-kernel , Adrian Hunter , Artem Bityutskiy , "stable [v4.9]" , Ralph Sennhauser From: Richard Weinberger Message-ID: Date: Thu, 30 Mar 2017 11:09:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1280 Lines: 41 Amir, Am 30.03.2017 um 11:07 schrieb Amir Goldstein: > On Thu, Mar 30, 2017 at 12:03 PM, Richard Weinberger wrote: >> Amir, >> >> Am 30.03.2017 um 10:59 schrieb Amir Goldstein: >>> On Thu, Mar 30, 2017 at 11:56 AM, Richard Weinberger wrote: >>>> It is perfectly fine to link a tmpfile back using linkat(). >>>> Since tmpfiles are created with a link count of 0 they appear >>>> on the orphan list, upon re-linking the inode has to be removed >>>> from the orphan list again. >>>> >>> >>> Looks good. >>> >>>> Cc: >>>> Cc: Ralph Sennhauser >>>> Cc: Amir Goldstein >> >>> typo: missing closing > >> >> Whoops, copied one byte too few from Thunderbird. :D >> Will fix before pushing. >> > > > It's worth mentioning the bug that Ralph reported. > The fact that overlayfs mount in v4.11-rc causes corruption of ubifs is much > more severe than what the current commit message implies (fix of a corner case). Okay, I'll add more drama to the commit message. Usually I assume that stable patches for filesystems are considered as something serious. > I would also add # v4.9 hint to stable tag, just to be nice ;-) Isn't this why we have the Fixes tag? Thanks, //richard