Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932715AbdC3J0i (ORCPT ); Thu, 30 Mar 2017 05:26:38 -0400 Received: from mail-lf0-f49.google.com ([209.85.215.49]:34603 "EHLO mail-lf0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932598AbdC3J0f (ORCPT ); Thu, 30 Mar 2017 05:26:35 -0400 Subject: Re: [PATCH v7 0/7] Implement clocksource for rockchip SoC using rockchip timer To: Alexander Kochetkov , Heiko Stuebner , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org References: <1490197714-25415-1-git-send-email-al.kochet@gmail.com> Cc: Thomas Gleixner , Mark Rutland , Rob Herring , Russell King , Caesar Wang , Huang Tao From: Daniel Lezcano Message-ID: <95a1610f-a784-83de-135d-0e742a34ce17@linaro.org> Date: Thu, 30 Mar 2017 11:26:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3363 Lines: 90 On 29/03/2017 15:22, Alexander Kochetkov wrote: > Hello, Daniel. Hi Alexander, > Due to recent comments from Mark[1], may be is better to apply v6[2] series instead of v7[3]? > Because my main goal was to fix wall time on rk3188. And I did it the same way how that was > already done for other timer drivers (one of possible solution). > > You can rename CLOCKSOURCE_OF to TIMER_OF later. I can help with that, but I don’t > think it is good idea to combine my changes and timer framework cleanups/improvements > into single series. > > And I thinks, that probably is is better to drop [3] and [4] and revert 0c8893c9095d ("clockevents: Add a > clkevt-of mechanism like clksrc-of»). > > What do you think? I share your opinion. -- Daniel > [1] https://lkml.org/lkml/2017/3/29/286 > [2] https://lkml.org/lkml/2017/1/31/401 > [3] https://lkml.org/lkml/2017/3/22/508 > [4] https://lkml.org/lkml/2017/3/22/420 > [5] https://lkml.org/lkml/2017/3/22/426 > >> 22 марта 2017 г., в 18:48, Alexander Kochetkov написал(а): >> >> Hello, Daniel, Heiko. >> >> Here is try 7 :) Could you please take a look into it? >> >> rockchip_timer init code implemented using CLOCKEVENT_OF_DECLARE() >> introduced in commit 0c8893c9095d ("clockevents: Add a clkevt-of >> mechanism like clksrc-of") >> >> There is change in the arch/arm/mach-rockchip/rockchip.c. >> >> This series should be applied after the commit: >> https://lkml.org/lkml/2017/3/22/426 >> >> As without the commit, you will get linker error ("clkevt-probe.c:63: >> undefined reference to `__clkevt_of_table’") >> >> Regards, >> Alexander. >> >> >> Alexander Kochetkov (6): >> dt-bindings: clarify compatible property for rockchip timers >> ARM: dts: rockchip: update compatible property for rk322x timer >> ARM: dts: rockchip: add clockevent attribute to rockchip timers >> clocksource/drivers/rockchip_timer: implement clocksource timer >> ARM: dts: rockchip: add timer entries to rk3188 SoC >> ARM: dts: rockchip: disable arm-global-timer for rk3188 >> >> Daniel Lezcano (1): >> clocksource/drivers/clksrc-evt-probe: Describe with the DT both the >> clocksource and the clockevent >> >> .../bindings/timer/rockchip,rk-timer.txt | 12 +- >> Documentation/devicetree/bindings/timer/timer.txt | 38 ++++ >> arch/arm/boot/dts/rk3036.dtsi | 1 + >> arch/arm/boot/dts/rk3188.dtsi | 19 ++ >> arch/arm/boot/dts/rk322x.dtsi | 3 +- >> arch/arm/boot/dts/rk3288.dtsi | 1 + >> arch/arm/mach-rockchip/rockchip.c | 2 + >> arch/arm64/boot/dts/rockchip/rk3368.dtsi | 1 + >> drivers/clocksource/Kconfig | 2 + >> drivers/clocksource/clkevt-probe.c | 7 + >> drivers/clocksource/clksrc-probe.c | 7 + >> drivers/clocksource/rockchip_timer.c | 215 ++++++++++++++------ >> 12 files changed, 241 insertions(+), 67 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/timer/timer.txt >> >> -- >> 1.7.9.5 >> > -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog