Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932509AbdC3Jh5 (ORCPT ); Thu, 30 Mar 2017 05:37:57 -0400 Received: from mga14.intel.com ([192.55.52.115]:54604 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753263AbdC3Jhz (ORCPT ); Thu, 30 Mar 2017 05:37:55 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,246,1486454400"; d="scan'208";a="1113590393" Subject: Re: [PATCH] ubifs: Fix O_TMPFILE corner case in ubifs_link() To: Richard Weinberger , linux-mtd@lists.infradead.org References: <1490864181-2192-1-git-send-email-richard@nod.at> Cc: linux-kernel@vger.kernel.org, dedekind1@gmail.com, stable@vger.kernel.org, Ralph Sennhauser , Amir Goldstein From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: Date: Thu, 30 Mar 2017 12:32:18 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <1490864181-2192-1-git-send-email-richard@nod.at> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1285 Lines: 33 On 30/03/17 11:56, Richard Weinberger wrote: > It is perfectly fine to link a tmpfile back using linkat(). > Since tmpfiles are created with a link count of 0 they appear > on the orphan list, upon re-linking the inode has to be removed > from the orphan list again. > > Cc: > Cc: Ralph Sennhauser > Cc: Amir Goldstein Reported-by: Ralph Sennhauser > Tested-by: Ralph Sennhauser > Reported-by: Amir Goldstein Fixes: 474b93704f321 ("ubifs: Implement O_TMPFILE") > Signed-off-by: Richard Weinberger > --- > fs/ubifs/dir.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/fs/ubifs/dir.c b/fs/ubifs/dir.c > index 0858213a4e63..0139155045fe 100644 > --- a/fs/ubifs/dir.c > +++ b/fs/ubifs/dir.c > @@ -748,6 +748,11 @@ static int ubifs_link(struct dentry *old_dentry, struct inode *dir, > goto out_fname; > > lock_2_inodes(dir, inode); > + > + /* Handle O_TMPFILE corner case, it is allowed to link a O_TMPFILE. */ > + if (inode->i_nlink == 0) > + ubifs_delete_orphan(c, inode->i_ino); Isn't there also a deletion inode in the journal? If the recovery sees that won't it delete the file data?