Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932864AbdC3Jtc (ORCPT ); Thu, 30 Mar 2017 05:49:32 -0400 Received: from b.ns.miles-group.at ([95.130.255.144]:44724 "EHLO radon.swed.at" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932265AbdC3Jtb (ORCPT ); Thu, 30 Mar 2017 05:49:31 -0400 Subject: Re: [PATCH] ubifs: Fix O_TMPFILE corner case in ubifs_link() To: Adrian Hunter , linux-mtd@lists.infradead.org References: <1490864181-2192-1-git-send-email-richard@nod.at> Cc: linux-kernel@vger.kernel.org, dedekind1@gmail.com, stable@vger.kernel.org, Ralph Sennhauser , Amir Goldstein From: Richard Weinberger Message-ID: Date: Thu, 30 Mar 2017 11:49:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 791 Lines: 23 Am 30.03.2017 um 11:32 schrieb Adrian Hunter: >> diff --git a/fs/ubifs/dir.c b/fs/ubifs/dir.c >> index 0858213a4e63..0139155045fe 100644 >> --- a/fs/ubifs/dir.c >> +++ b/fs/ubifs/dir.c >> @@ -748,6 +748,11 @@ static int ubifs_link(struct dentry *old_dentry, struct inode *dir, >> goto out_fname; >> >> lock_2_inodes(dir, inode); >> + >> + /* Handle O_TMPFILE corner case, it is allowed to link a O_TMPFILE. */ >> + if (inode->i_nlink == 0) >> + ubifs_delete_orphan(c, inode->i_ino); > > Isn't there also a deletion inode in the journal? If the recovery sees that > won't it delete the file data? Yes, but ubifs_link() adds a new journal entry which revives the inode. This should cancel out the deletion, right? You know the UBIFS journal better than I do. :-) Thanks, //richard