Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933826AbdC3Kiv (ORCPT ); Thu, 30 Mar 2017 06:38:51 -0400 Received: from mga04.intel.com ([192.55.52.120]:15946 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932327AbdC3Kit (ORCPT ); Thu, 30 Mar 2017 06:38:49 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,246,1486454400"; d="asc'?scan'208";a="241987790" From: Felipe Balbi To: cristian.birsan@microchip.com, nicolas.ferre@atmel.com, gregkh@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Cc: ludovic.desroches@atmel.com, alexandre.belloni@free-electrons.com, boris.brezillon@free-electrons.com, Cristian Birsan Subject: Re: [PATCH linux-next v2 1/4] usb: gadget: udc: atmel: Check fifo configuration values against device tree In-Reply-To: <4b91a4973e19a5b7ac05d5e0f5b4dcc8cffb75cf.1490715349.git.cristian.birsan@microchip.com> References: <4b91a4973e19a5b7ac05d5e0f5b4dcc8cffb75cf.1490715349.git.cristian.birsan@microchip.com> Date: Thu, 30 Mar 2017 13:38:34 +0300 Message-ID: <87fuhvjbh1.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2171 Lines: 61 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, cristian.birsan@microchip.com writes: > From: Cristian Birsan > > Check fifo configuration values against device tree values for endpoint f= ifo > in auto configuration mode (fifo_mode=3D0). > > Signed-off-by: Cristian Birsan > --- > drivers/usb/gadget/udc/atmel_usba_udc.c | 24 ++++++++++++++++++++++-- > 1 file changed, 22 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget= /udc/atmel_usba_udc.c > index 2035906b..3fd43fb 100644 > --- a/drivers/usb/gadget/udc/atmel_usba_udc.c > +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c > @@ -2118,14 +2118,34 @@ static struct usba_ep * atmel_udc_of_init(struct = platform_device *pdev, > dev_err(&pdev->dev, "of_probe: fifo-size error(%d)\n", ret); > goto err; > } > - ep->fifo_size =3D fifo_mode ? udc->fifo_cfg[i].fifo_size : val; > + if (fifo_mode) { > + if (val < udc->fifo_cfg[i].fifo_size) { > + dev_warn(&pdev->dev, > + "of_probe: fifo-size table value not supported by HW, using DT val= ue\n"); 114 characters long. Is this even worth a warning? probably not. =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAljc4CoACgkQzL64meEa mQadSQ/+NHPiLr2BLWK8WJHhXTlvHCzn7Sl+gBoVMyhOQWWY+ScgFSqu21lBgpMJ RQcNk1Af8tljJc0596KPgVg11XyvsuhBv4m7XrNUrMhZJn7v4a+fVzOd3L1tLPsg qNymxdBpaW0b14IXHdE7wtbf5ynWhRxCoEsFYlWHRQHqx7KXXyihgB6bP+RZS6Pa ZVJx46MbYMSGlIEqyDnwEnwHwpfXD6Fs3onMWtHCe1MF1FanLA3WfWHMn6o5hM6P /QarxJJWk2IY/93twHjPLkLgOjzEFF6FIS/6u8KHAkdYlvYX95S7AkAh52YxoJqe RwSS4q1fDlor32DUUaCFaqC1L4+Pi02tRPCyJuesTSlNDSt2pGvPd5cQq9BBkLM/ WG67TaCAgp8dP2B1PRauzEdyYDbz7gK5zlGK4yOdS5rZMoDLc1pNPHWF8cbo6+00 EzMlftL+I0kIOaiQo4l9D7wHM1QFNyve1yWCywM5QqxmnKQrHUiXEIFX/HYe3URv KGyXS713NwZcQhDVF3V0W7AGQeAQU9ScqgkW7x0QQ6lXEJzohH/3yqjwuiRBOA5P 9rmj2IuhwrpoaUNgDGKebZhOiv2//dnkYEP2sbFYClnQUZ75w/Uv+3ZH2Iz9Uj2b VaZyqzI0/9XiDa/0AoeLruTKJQngTRV59/yuVpkl3/I95CbyoMM= =JlOs -----END PGP SIGNATURE----- --=-=-=--