Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933694AbdC3KkA (ORCPT ); Thu, 30 Mar 2017 06:40:00 -0400 Received: from mga11.intel.com ([192.55.52.93]:21152 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932989AbdC3Kj6 (ORCPT ); Thu, 30 Mar 2017 06:39:58 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,246,1486454400"; d="asc'?scan'208";a="66845165" From: Felipe Balbi To: cristian.birsan@microchip.com, nicolas.ferre@atmel.com, gregkh@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Cc: ludovic.desroches@atmel.com, alexandre.belloni@free-electrons.com, boris.brezillon@free-electrons.com, Cristian Birsan Subject: Re: [PATCH linux-next v2 3/4] usb: gadget: udc: atmel: Use dev_warn() to display EP configuration error In-Reply-To: <676bd6d232af7ce08f2fb1f7e4188fc20ef751db.1490715349.git.cristian.birsan@microchip.com> References: <676bd6d232af7ce08f2fb1f7e4188fc20ef751db.1490715349.git.cristian.birsan@microchip.com> Date: Thu, 30 Mar 2017 13:39:43 +0300 Message-ID: <87d1czjbf4.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1887 Lines: 55 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, cristian.birsan@microchip.com writes: > From: Cristian Birsan > > Use dev_warn() to display EP configuration error to avoid silent failure. > > Signed-off-by: Cristian Birsan > --- > drivers/usb/gadget/udc/atmel_usba_udc.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget= /udc/atmel_usba_udc.c > index 2bd8410..942c9c9 100644 > --- a/drivers/usb/gadget/udc/atmel_usba_udc.c > +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c > @@ -1851,7 +1851,7 @@ static irqreturn_t usba_udc_irq(int irq, void *devi= d) > * but it's clearly harmless... > */ > if (!(usba_ep_readl(ep0, CFG) & USBA_EPT_MAPPED)) > - dev_dbg(&udc->pdev->dev, > + dev_warn(&udc->pdev->dev, seems like dev_err() would've been more fitting. =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAljc4G8ACgkQzL64meEa mQZINg//SVEGr01Ar6H2nVk0Pgo5AanDXmsGNW5fiJ0nx7GcXky0V8DofCwmnii4 lfyWSrkWpqsMEVxSTYk9FyFtHMJYKAtWZ/xwozYreZ5yDiPW53RenZiL6rnv0jOd XAycFpbjVw0laAgTHvlenqZ9w41TUn+ck+iykeIht3ZIwkgKabIpCGyuGqq4xlYb Fmnf519kI5SUUSMGDoVACZDe4R2zMW1PTVAzj/h9+aGzbUUaeuL8h3GfhSNF5Bh/ MhAd3kZk7exN6w55MFWnH+QkHM87EdhYsvES1mtNvN+FPCEQI5zoVFvpYIX7Ejnl GoqISrk8Sq7hHtLf1rajV4wqqJgTsJyI7VTxIGkZ1XntB2f2h28N74NuZPF/RmZB btwYQat5PjRhu7mdDhwXeGWuHwBbVLolIKa+oQ2yOQbgl5YlGAEYLBfpgRsUWRAV poWfUqJLix3Cis8Bwpx8kpobkuZWs+gi5vXUkVFTl+sqbPrl8RDrmqcF+S78uNSD aKKsxCG/8Y0+HUB4dc38cTqoOl3xH7taAyq6tRMNjZ3jha3f3EpK9AVnoe9KEpgu 5l8qXNoKZkp3f1Uyc5zYOJM9mQ+YxJ8EUu0KLL1vQ+P5roZyNxXWuCqwhJPJPRH3 +Cd+oaoNPbrHBFt/Q2Ljdd6JMrHqN0apdp1Ltaqgc2rTF9kxInk= =46N+ -----END PGP SIGNATURE----- --=-=-=--