Date: Thu, 30 Mar 2017 11:46:08 +0100
From: Mark Rutland <mark.rutland@arm.com>
To: Anurup M <anurupvasu@gmail.com>
Cc: will.deacon@arm.com, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, anurup.m@huawei.com,
        zhangshaokun@hisilicon.com, tanxiaojun@huawei.com,
        xuwei5@hisilicon.com, sanil.kumar@hisilicon.com, john.garry@huawei.com,
        gabriele.paoloni@huawei.com, shiju.jose@huawei.com,
        huangdaode@hisilicon.com, linuxarm@huawei.com, dikshit.n@huawei.com,
        shyju.pv@huawei.com
Subject: Re: [PATCH v6 07/11] drivers: perf: hisi: Add support for Hisilicon
 SoC event counters
Message-ID: <20170330104607.GC16211@leverpostej>
References: <1489127311-112778-1-git-send-email-anurup.m@huawei.com>
 <20170321165252.GA29116@leverpostej>
 <58DCD47C.2010501@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <58DCD47C.2010501@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1301
Lines: 37

On Thu, Mar 30, 2017 at 03:18:44PM +0530, Anurup M wrote:
> 
> 
> On Tuesday 21 March 2017 10:22 PM, Mark Rutland wrote:
> >+static int hisi_hw_perf_event_init(struct perf_event *event)
> >>+{
> >>+	struct hw_perf_event *hwc = &event->hw;
> >>+	struct hisi_pmu *hisi_pmu = to_hisi_pmu(event->pmu);
> >>+	struct device *dev = hisi_pmu->dev;
> >>+
> >>>+	/*
> >>>+	 * We must NOT create groups containing mixed PMUs, although
> >>>+	 * software events are acceptable
> >>>+	 */
> >>>+	if (event->group_leader->pmu != event->pmu &&
> >>>+	    !is_software_event(event->group_leader))
> >>>+		return -EINVAL;
> >>>+
> >>>+	list_for_each_entry(sibling, &event->group_leader->sibling_list,
> >>>+			    group_entry)
> >>>+		if (sibling->pmu != event->pmu && !is_software_event(sibling))
> >>>+			return -EINVAL;
> >Please also check the number of counters.
> 
> Sorry, I could not follow this comment correctly. Could you please explain ?
> I check the available counters and update used mask in pmu_add -->
> get_event_index

What I meant was that here we should ensure that a group does not
contain more events than can fit into counters.

For example, if the HW had two counters, we should reject any group with
more than two events. Such groups can never be scheduled, and make no
sense.

Thanks,
Mark.