Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933290AbdC3LGz (ORCPT ); Thu, 30 Mar 2017 07:06:55 -0400 Received: from mx0b-0014ca01.pphosted.com ([208.86.201.193]:47083 "EHLO mx0a-0014ca01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932541AbdC3LGy (ORCPT ); Thu, 30 Mar 2017 07:06:54 -0400 X-CrossPremisesHeadersFilteredBySendConnector: maileu3.global.cadence.com Date: Thu, 30 Mar 2017 12:06:36 +0100 From: Piotr Sroka Message-ID: <201703301106.v2UB6aj4001807@lvloginb.cadence.com> To: Masahiro Yamada CC: linux-mmc , Adrian Hunter , Ulf Hansson , Linux Kernel Mailing List , Piotr Subject: RE: [v5 2/4] dt-bindings: mmc: add description of PHY delays for sdhci-cadence In-Reply-To: References: <1490106736-2242-1-git-send-email-piotrs@cadence.com> <1490106781-3129-1-git-send-email-piotrs@cadence.com> MIME-Version: 1.0 Content-Type: text/plain X-OrganizationHeadersPreserved: maileu3.global.cadence.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1296 Lines: 44 Hi Masahiro 2017-03-22 16:30 Masahiro Yamada : > 2017-03-21 23:33 GMT+09:00 Piotr Sroka : > > DTS properties are used instead of fixed data > > because PHY settings can be different for different chips/boards. > > Add description of new DLL PHY delays. > > > > Signed-off-by: Piotr Sroka > > --- > > Changes for v2: > > - file was created in v2. It was a part of driver source file patch. > > - most delays were moved from dts file > > to data associated with an SoC specific compatible > > - description of delays was updated to be more clearly > > --- > > Changes for v3: > > - move all delays back to dts because they are also boards dependent > > - prefix all of the Cadence-specific properties with cdns prefix > > --- > > Changes for v4: > > - change the beginning of the commit subject > > --- > > Changes for v5: > > - change name of property to be consistent with timing modes > > available in Linux > > > As I gave Reviewed-by in v4 already, this looks good to me. > > > Reviewed-by: Masahiro Yamada > > > As I said before, > once you get Reviewed/Acked tags, > please include them in your later version. > Ok. I will remember next time. -- Best Regards Piotr Sroka