Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933364AbdC3M12 (ORCPT ); Thu, 30 Mar 2017 08:27:28 -0400 Received: from b.ns.miles-group.at ([95.130.255.144]:44724 "EHLO radon.swed.at" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754144AbdC3M11 (ORCPT ); Thu, 30 Mar 2017 08:27:27 -0400 Subject: Re: [PATCH] ubifs: Fix O_TMPFILE corner case in ubifs_link() To: Adrian Hunter , linux-mtd@lists.infradead.org References: <1490864181-2192-1-git-send-email-richard@nod.at> <4c7a176b-6132-7936-a04f-d4def5e56320@nod.at> <646ae733-5037-3072-7151-b055a8fa1521@intel.com> Cc: linux-kernel@vger.kernel.org, dedekind1@gmail.com, stable@vger.kernel.org, Ralph Sennhauser , Amir Goldstein From: Richard Weinberger Message-ID: Date: Thu, 30 Mar 2017 14:27:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <646ae733-5037-3072-7151-b055a8fa1521@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 641 Lines: 17 Am 30.03.2017 um 13:57 schrieb Adrian Hunter: >> Reading deeper into the proved that I was wrong. >> AFAIKT UBIFS' journal has currently no way to revive a deleted inode. >> So, we have to think about a new solution. > > Deleting the orphan looks right. Just need to understand whether the > recovery would do the right thing - actually it looks like O_TMPFILE might > be OK and in other case we might be failing to remove nodes with sequence > numbers greater than the deletion inode. Sadly it does not the right thing. I'm currently investigating why and how to deal with it. I also managed to trigger that case. :( Thanks, //richard