Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933420AbdC3MzG (ORCPT ); Thu, 30 Mar 2017 08:55:06 -0400 Received: from bny206.haproxy.com ([37.58.153.206]:58805 "EHLO smtp.exceliance.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750995AbdC3MzF (ORCPT ); Thu, 30 Mar 2017 08:55:05 -0400 Date: Thu, 30 Mar 2017 14:54:42 +0200 From: Willy TARREAU To: Andy Shevchenko Cc: Geert Uytterhoeven , Miguel Ojeda Sandonis , Arnd Bergmann , Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" , Linus Walleij Subject: Re: [PATCH v1 1/2] auxdisplay: Move panel.c to drivers/auxdisplay folder Message-ID: <20170330125442.GE793@haproxy.com> References: <20170324140635.56565-1-andriy.shevchenko@linux.intel.com> <1490365775.21738.7.camel@linux.intel.com> <20170327081111.GA28802@haproxy.com> <20170327090153.GC28802@haproxy.com> <1490873226.708.68.camel@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1490873226.708.68.camel@linux.intel.com> User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1436 Lines: 32 On Thu, Mar 30, 2017 at 02:27:06PM +0300, Andy Shevchenko wrote: > On Mon, 2017-03-27 at 11:01 +0200, Willy TARREAU wrote: > > On Mon, Mar 27, 2017 at 10:26:07AM +0200, Geert Uytterhoeven wrote: > > > On Mon, Mar 27, 2017 at 10:11 AM, Willy TARREAU > > m> wrote: > > > > On Fri, Mar 24, 2017 at 04:19:43PM +0100, Geert Uytterhoeven > > > > wrote: > > > > > On Fri, Mar 24, 2017 at 3:29 PM, Andy Shevchenko > > > > > wrote: > > > > > > On Fri, 2017-03-24 at 15:19 +0100, Geert Uytterhoeven wrote: > > > > > > > On Fri, Mar 24, 2017 at 3:06 PM, Andy Shevchenko > > > > > > > wrote: > > > In fact here the output signals should be seen as a shared bus with > > multiple > > chip select signals. Note that in some designs it's even possible that > > pressing > > multiple buttons will cause crap to be sent to the LCD by short- > > circuiting > > the lines (if no diodes are used) but it might be acceptable for many > > designs, > > especially the DIY field where the principle is "don't do it". > > So, summarizing the comments are we okay to proceed or there is a clear > objection? I don't know all the impacts, but as long as it continues to work I'm totally fine with seeing the code being changed and refactored. It already got a nice improvement with this series. Furthermore I can occasionally give it a try if that helps :-) Willy