Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933945AbdC3Nm7 (ORCPT ); Thu, 30 Mar 2017 09:42:59 -0400 Received: from lb1-smtp-cloud6.xs4all.net ([194.109.24.24]:37587 "EHLO lb1-smtp-cloud6.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933670AbdC3Nm5 (ORCPT ); Thu, 30 Mar 2017 09:42:57 -0400 Subject: Re: [PATCH 3/3] [media] cobalt: Use v4l2_calc_timeperframe helper To: Jose Abreu , linux-media@vger.kernel.org References: <070c9e71b359c0f6da7410b5ab9207210925549a.1490095965.git.joabreu@synopsys.com> Cc: Carlos Palminha , Mauro Carvalho Chehab , Hans Verkuil , linux-kernel@vger.kernel.org From: Hans Verkuil Message-ID: Date: Thu, 30 Mar 2017 15:42:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <070c9e71b359c0f6da7410b5ab9207210925549a.1490095965.git.joabreu@synopsys.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1952 Lines: 58 Hi Jose, On 21/03/17 12:49, Jose Abreu wrote: > Currently, cobalt driver always returns 60fps in g_parm. > This patch uses the new v4l2_calc_timeperframe helper to > calculate the time per frame value. I can verify that g_parm works, so: Tested-by: Hans Verkuil However, the adv7604 pixelclock detection resolution is only 0.25 MHz, so it can't tell the difference between 24 and 23.97 Hz. I can't set the new V4L2_DV_FL_CAN_DETECT_REDUCED_FPS flag there. It might be possible to implement this for the adv7842 receiver, I think that that hardware is much more precise. I would have to try this, but that will have to wait until Friday next week. Regards, Hans > > Signed-off-by: Jose Abreu > Cc: Carlos Palminha > Cc: Mauro Carvalho Chehab > Cc: Hans Verkuil > Cc: linux-media@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > --- > drivers/media/pci/cobalt/cobalt-v4l2.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/pci/cobalt/cobalt-v4l2.c b/drivers/media/pci/cobalt/cobalt-v4l2.c > index def4a3b..25532ae 100644 > --- a/drivers/media/pci/cobalt/cobalt-v4l2.c > +++ b/drivers/media/pci/cobalt/cobalt-v4l2.c > @@ -1076,10 +1076,15 @@ static int cobalt_subscribe_event(struct v4l2_fh *fh, > > static int cobalt_g_parm(struct file *file, void *fh, struct v4l2_streamparm *a) > { > + struct cobalt_stream *s = video_drvdata(file); > + struct v4l2_fract fps; > + > if (a->type != V4L2_BUF_TYPE_VIDEO_CAPTURE) > return -EINVAL; > - a->parm.capture.timeperframe.numerator = 1; > - a->parm.capture.timeperframe.denominator = 60; > + > + fps = v4l2_calc_timeperframe(&s->timings); > + a->parm.capture.timeperframe.numerator = fps.numerator; > + a->parm.capture.timeperframe.denominator = fps.denominator; > a->parm.capture.readbuffers = 3; > return 0; > } >