Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934115AbdC3Nuz (ORCPT ); Thu, 30 Mar 2017 09:50:55 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:40546 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933126AbdC3Nux (ORCPT ); Thu, 30 Mar 2017 09:50:53 -0400 Date: Thu, 30 Mar 2017 15:50:50 +0200 From: Andrew Lunn To: Vivien Didelot Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli Subject: Re: [PATCH net-next 4/9] net: dsa: mv88e6xxx: allocate the number of ports Message-ID: <20170330135050.GD17879@lunn.ch> References: <20170329203020.27042-1-vivien.didelot@savoirfairelinux.com> <20170329203020.27042-5-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170329203020.27042-5-vivien.didelot@savoirfairelinux.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 377 Lines: 11 On Wed, Mar 29, 2017 at 04:30:15PM -0400, Vivien Didelot wrote: > The current code allocates DSA_MAX_PORTS ports for a Marvell dsa_switch > structure. Provide the exact number of ports so the corresponding > ds->num_ports is accurate. Hi Vivien Is net/dsa/dsa.c: dsa_switch_setup() still used? If it is, won't that invalidate your assumption about ds->num_ports. Andrew