Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934038AbdC3OEX (ORCPT ); Thu, 30 Mar 2017 10:04:23 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:40571 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933426AbdC3OEW (ORCPT ); Thu, 30 Mar 2017 10:04:22 -0400 Date: Thu, 30 Mar 2017 16:04:17 +0200 From: Andrew Lunn To: Vivien Didelot Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli Subject: Re: [PATCH net-next 6/9] net: dsa: mv88e6xxx: factorize in-chip bridge map Message-ID: <20170330140417.GF17879@lunn.ch> References: <20170329203020.27042-1-vivien.didelot@savoirfairelinux.com> <20170329203020.27042-7-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170329203020.27042-7-vivien.didelot@savoirfairelinux.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 450 Lines: 14 On Wed, Mar 29, 2017 at 04:30:17PM -0400, Vivien Didelot wrote: > Factorize the code in the DSA port_bridge_{join,leave} routines used to > program the port VLAN map of all local ports of a given bridge group. > > In the meantime shorten the _mv88e6xxx_port_based_vlan_map to get rid of > the old underscore prefix naming convention. Hi Vivien "At the same time ..." would be better English. Reviewed-by: Andrew Lunn Andrew