Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934125AbdC3OtR (ORCPT ); Thu, 30 Mar 2017 10:49:17 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:45782 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933768AbdC3OtP (ORCPT ); Thu, 30 Mar 2017 10:49:15 -0400 Date: Thu, 30 Mar 2017 15:48:48 +0100 From: Al Viro To: Martin Schwidefsky Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Linus Torvalds , Richard Henderson , Russell King , Will Deacon , Haavard Skinnemoen , Vineet Gupta , Steven Miao , Jesper Nilsson , Mark Salter , Yoshinori Sato , Richard Kuo , Tony Luck , Geert Uytterhoeven , James Hogan , Michal Simek , David Howells , Ley Foon Tan , Jonas Bonn , Helge Deller , Ralf Baechle , Benjamin Herrenschmidt , Chen Liqin , "David S. Miller" , Chris Metcalf , Richard Weinberger , Guan Xuetao , Thomas Gleixner , Chris Zankel Subject: Re: [RFC][CFT][PATCHSET v1] uaccess unification Message-ID: <20170330144847.GN29622@ZenIV.linux.org.uk> References: <20170329055706.GH29622@ZenIV.linux.org.uk> <20170330143212.31353830@mschwideX1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170330143212.31353830@mschwideX1> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 977 Lines: 20 On Thu, Mar 30, 2017 at 02:32:12PM +0200, Martin Schwidefsky wrote: > On Wed, 29 Mar 2017 06:57:06 +0100 > Al Viro wrote: > > > The patchset currently in vfs.git#work.uaccess is the result; > > there's more work to do, but it takes care of a large part of the > > problems. About 2.8KLoc removed, a lot of cruft is gone and semantics > > is hopefully in sync now. All but two architectures (ia64 and metag) > > had been switched to new mechanism; for these two I'm afraid that I'll > > need serious help from maintainers. > > I have tested the code in vfs.git#work.uaccess and in principle it works > for s390. I found one bug which would return an incorrect result > for copy_from_user if the access faults on the last page of the copy. > In that case the new code would return 0 instead of the remaining bytes. > > This patch snippet should fix it, please just merge it into commit > "s390: get rid of zeroing, switch to RAW_COPY_USER" Done.