Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934280AbdC3O6O (ORCPT ); Thu, 30 Mar 2017 10:58:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51740 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934124AbdC3O6B (ORCPT ); Thu, 30 Mar 2017 10:58:01 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7CF132560 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=mst@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 7CF132560 Date: Thu, 30 Mar 2017 17:57:59 +0300 From: "Michael S. Tsirkin" To: Cornelia Huck Cc: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, Heiko Carstens , John Fastabend , Sudeep Dutt , virtualization@lists.linux-foundation.org, Ashutosh Dixit , Martin Schwidefsky Subject: Re: [PATCH 2/6] virtio: add context flag to find vqs Message-ID: <20170330175726-mutt-send-email-mst@kernel.org> References: <1490820507-8005-1-git-send-email-mst@redhat.com> <1490820507-8005-3-git-send-email-mst@redhat.com> <20170330091731.1b54a2e1.cornelia.huck@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170330091731.1b54a2e1.cornelia.huck@de.ibm.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Thu, 30 Mar 2017 14:58:00 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1364 Lines: 35 On Thu, Mar 30, 2017 at 09:17:31AM +0200, Cornelia Huck wrote: > On Wed, 29 Mar 2017 23:48:51 +0300 > "Michael S. Tsirkin" wrote: > > > Allows maintaining extra context per vq. For ease of use, passing in > > NULL is legal and disables the feature for all vqs. > > > > Signed-off-by: Michael S. Tsirkin > > --- > > drivers/misc/mic/vop/vop_main.c | 9 ++++++--- > > drivers/s390/virtio/kvm_virtio.c | 6 ++++-- > > drivers/s390/virtio/virtio_ccw.c | 7 ++++--- > > drivers/virtio/virtio_mmio.c | 8 +++++--- > > drivers/virtio/virtio_pci_common.c | 18 +++++++++++------- > > drivers/virtio/virtio_pci_common.h | 4 +++- > > drivers/virtio/virtio_pci_legacy.c | 4 +++- > > drivers/virtio/virtio_pci_modern.c | 12 ++++++++---- > > drivers/virtio/virtio_ring.c | 7 +++++-- > > include/linux/virtio_config.h | 18 +++++++++++++++--- > > include/linux/virtio_ring.h | 3 +++ > > 11 files changed, 67 insertions(+), 29 deletions(-) > > This series really needs a cover letter, explaining the motivation for > adding this context. True. Will try to improve that for v2. > From what I understand, you want to track some length parameter in > virtio-net. As you don't use indirect descriptors in that case, you > want to use a context instead. Did I get this correctly? Exactly. -- MST