Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934342AbdC3PkY (ORCPT ); Thu, 30 Mar 2017 11:40:24 -0400 Received: from 7of9.schinagl.nl ([62.251.20.244]:58568 "EHLO 7of9.schinagl.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934443AbdC3PkB (ORCPT ); Thu, 30 Mar 2017 11:40:01 -0400 Date: Thu, 30 Mar 2017 17:39:39 +0200 User-Agent: K-9 Mail for Android In-Reply-To: <2faa7420-0a54-e77f-0da2-80f6dfcf9710@ti.com> References: <20170329184431.6226-1-oliver@schinagl.nl> <6be65e8b-eea4-08ed-0b30-5c0608764a83@ti.com> <2faa7420-0a54-e77f-0da2-80f6dfcf9710@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Subject: Re: [PATCH] serial: Do not treat the IIR register as a bitfield To: Vignesh R , Greg Kroah-Hartman , Jiri Slaby , Laxman Dewangan , Stephen Warren , Thierry Reding , Alexandre Courbot , "David S . Miller" CC: "dev@linux-sunxi.org" , Ed Blake , Andy Shevchenko , Alexander Sverdlin , Yegor Yefremov , Wan Ahmad Zainie , Kefeng Wang , Heikki Krogerus , Heiko Stuebner , Jason Uy , Douglas Anderson , Peter Hurley , Tony Lindgren , Thor Thayer , David Lechner , Jan Kiszka , "linux-serial@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "sparclinux@vger.kernel.org" From: Olliver Schinagl Message-ID: <97434C93-32EF-4742-838D-4C783E5ECC45@schinagl.nl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v2UFeYxa017535 Content-Length: 2236 Lines: 58 Hey Vignesh, On March 30, 2017 9:57:19 AM CEST, Vignesh R wrote: > > >On Thursday 30 March 2017 12:13 PM, Olliver Schinagl wrote: >> >> >> On March 30, 2017 8:15:29 AM CEST, Vignesh R wrote: >>> Hi, >>> >>> On Thursday 30 March 2017 12:14 AM, Olliver Schinagl wrote: >>>> diff --git a/include/uapi/linux/serial_reg.h >>> b/include/uapi/linux/serial_reg.h >>>> index 5db76880b4ad..489522389a10 100644 >>>> --- a/include/uapi/linux/serial_reg.h >>>> +++ b/include/uapi/linux/serial_reg.h >>>> @@ -31,18 +31,18 @@ >>>> #define UART_IERX_SLEEP 0x10 /* Enable sleep mode */ >>>> >>>> #define UART_IIR 2 /* In: Interrupt ID Register */ >>>> -#define UART_IIR_NO_INT 0x01 /* No interrupts pending */ >>>> -#define UART_IIR_ID 0x0e /* Mask for the interrupt ID */ >>>> #define UART_IIR_MSI 0x00 /* Modem status interrupt */ >>>> +#define UART_IIR_NO_INT 0x01 /* No interrupts pending */ >>>> #define UART_IIR_THRI 0x02 /* Transmitter holding register empty >*/ >>>> #define UART_IIR_RDI 0x04 /* Receiver data interrupt */ >>>> #define UART_IIR_RLSI 0x06 /* Receiver line status interrupt */ >>>> - >>>> #define UART_IIR_BUSY 0x07 /* DesignWare APB Busy Detect */ >>>> +#define UART_IIR_RX_TIMEOUT 0x0c /* DesignWare RX Timeout >interrupt >>> */ >> It was moved due to sorting. The comment could be changed maybe? I >renamed it from omap to dw as i believe the omap also uses the dw ip. >But i think it is a defacto standard mapping of the irr register? > >AFAIK, OMAP UART does not use DW core, please make these IDs generic to >avoid confusion. The ids are genetic, the comments are not. Ill update the comments to be generic, with the exception of the omap specific extended ones? Olliver > >> >>>> +#define UART_IIR_MASK 0x0f /* DesignWare IIR mask */ >>>> >>>> -#define UART_IIR_RX_TIMEOUT 0x0c /* OMAP RX Timeout interrupt */ >>> >>> You are removing UART_IIR_RX_TIMEOUT? Is this intended? >>> >>>> #define UART_IIR_XOFF 0x10 /* OMAP XOFF/Special Character */ >>>> #define UART_IIR_CTS_RTS_DSR 0x20 /* OMAP CTS/RTS/DSR Change */ >>>> +#define UART_IIR_EXT_MASK 0x30 /* OMAP extended IIR mask */ >> -- Sent from my Android device with K-9 Mail. Please excuse my brevity.