Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933866AbdC3Q6Y (ORCPT ); Thu, 30 Mar 2017 12:58:24 -0400 Received: from mail-wr0-f181.google.com ([209.85.128.181]:33722 "EHLO mail-wr0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932827AbdC3Q6W (ORCPT ); Thu, 30 Mar 2017 12:58:22 -0400 From: Gioh Kim To: jes.sorensen@gmail.com, neilb@suse.com Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org, Gioh Kim Subject: [PATCHv2] mdadm.c: fix compile error "switch condition has boolean value" Date: Thu, 30 Mar 2017 18:58:13 +0200 Message-Id: <1490893093-4666-1-git-send-email-gi-oh.kim@profitbricks.com> X-Mailer: git-send-email 2.5.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 917 Lines: 36 Remove a boolean expression in switch condition to prevent compile error of some compilers, for example, gcc version 5.2.1 20151010 (Ubuntu 5.2.1-22ubuntu2). Signed-off-by: Gioh Kim --- mdadm.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/mdadm.c b/mdadm.c index 0f32773..d6b5437 100644 --- a/mdadm.c +++ b/mdadm.c @@ -1965,14 +1965,12 @@ static int misc_list(struct mddev_dev *devlist, rv |= SetAction(dv->devname, c->action); continue; } - switch(dv->devname[0] == '/') { - case 0: - mdfd = open_dev(dv->devname); - if (mdfd >= 0) - break; - case 1: - mdfd = open_mddev(dv->devname, 1); - } + + if (dv->devname[0] != '/') + mdfd = open_dev(dv->devname); + if (dv->devname[0] == '/' || mdfd < 0) + mdfd = open_mddev(dv->devname, 1); + if (mdfd >= 0) { switch(dv->disposition) { case 'R': -- 2.5.0