DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 75DB76AAFD
Date: Thu, 30 Mar 2017 22:06:14 +0200
From: Jiri Benc <jbenc@redhat.com>
To: Yi-Hung Wei <yihung.wei@gmail.com>
Cc: joe@ovn.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2] openvswitch: Fix ovs_flow_key_update()
Message-ID: <20170330220614.7079d316@griffin>
In-Reply-To: <1490902563-19288-1-git-send-email-yihung.wei@gmail.com>
References: <1490902563-19288-1-git-send-email-yihung.wei@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 733
Lines: 17

On Thu, 30 Mar 2017 12:36:03 -0700, Yi-Hung Wei wrote:
> ovs_flow_key_update() is called when the flow key is invalid, and it is
> used to update and revalidate the flow key. Commit 329f45bc4f19
> ("openvswitch: add mac_proto field to the flow key") introduces mac_proto
> field to flow key and use it to determine whether the flow key is valid.
> However, the commit does not update the code path in ovs_flow_key_update()
> to revalidate the flow key which may cause BUG_ON() on execute_recirc().
> This patch addresses the aforementioned issue.
> 
> Fixes: 329f45bc4f19 ("openvswitch: add mac_proto field to the flow key")
> Signed-off-by: Yi-Hung Wei <yihung.wei@gmail.com>

Acked-by: Jiri Benc <jbenc@redhat.com>

Thanks!

 Jiri