Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934820AbdC3Vje (ORCPT ); Thu, 30 Mar 2017 17:39:34 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:35944 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933933AbdC3Vja (ORCPT ); Thu, 30 Mar 2017 17:39:30 -0400 X-IronPort-AV: E=Sophos;i="5.36,248,1486422000"; d="scan'208";a="266936099" Date: Thu, 30 Mar 2017 23:39:26 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Christopher Bostic cc: joel@jms.id.au, linux-kernel@vger.kernel.org, andrew@aj.id.au, alistair@popple.id.au, benh@kernel.crashing.org, "Edward A . James" , Jeremy Kerr , robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk, rostedt@goodmis.org, mingo@redhat.com, gregkh@linuxfoundation.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kbuild-all@01.org Subject: Re: [PATCH v4 19/23] drivers/fsi: Add GPIO based FSI master (fwd) Message-ID: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2662 Lines: 58 Is master on line 514 allocated with kmalloc, or the devm call on line 522? julia ---------- Forwarded message ---------- Date: Fri, 31 Mar 2017 00:15:09 +0800 From: kbuild test robot To: kbuild@01.org Cc: Julia Lawall Subject: Re: [PATCH v4 19/23] drivers/fsi: Add GPIO based FSI master Hi Chris, [auto build test WARNING on linus/master] [also build test WARNING on v4.11-rc4 next-20170330] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Christopher-Bostic/FSI-device-driver-implementation/20170330-184914 :::::: branch date: 5 hours ago :::::: commit date: 5 hours ago >> drivers/fsi/fsi-master-gpio.c:514:1-6: WARNING: invalid free of devm_ allocated data git remote add linux-review https://github.com/0day-ci/linux git remote update linux-review git checkout f4bd3b6a41c7a59e9ce2e65947a4d3dfc2ee4a29 vim +514 drivers/fsi/fsi-master-gpio.c f4bd3b6a Chris Bostic 2017-03-29 498 { f4bd3b6a Chris Bostic 2017-03-29 499 struct fsi_master_gpio *master = to_fsi_master_gpio(_master); f4bd3b6a Chris Bostic 2017-03-29 500 f4bd3b6a Chris Bostic 2017-03-29 501 if (link != 0) f4bd3b6a Chris Bostic 2017-03-29 502 return -ENODEV; f4bd3b6a Chris Bostic 2017-03-29 503 if (master->gpio_enable) f4bd3b6a Chris Bostic 2017-03-29 504 gpiod_set_value(master->gpio_enable, 1); f4bd3b6a Chris Bostic 2017-03-29 505 f4bd3b6a Chris Bostic 2017-03-29 506 return 0; f4bd3b6a Chris Bostic 2017-03-29 507 } f4bd3b6a Chris Bostic 2017-03-29 508 f4bd3b6a Chris Bostic 2017-03-29 509 static void fsi_master_gpio_release(struct device *dev) f4bd3b6a Chris Bostic 2017-03-29 510 { f4bd3b6a Chris Bostic 2017-03-29 511 struct fsi_master_gpio *master = to_fsi_master_gpio( f4bd3b6a Chris Bostic 2017-03-29 512 dev_to_fsi_master(dev)); f4bd3b6a Chris Bostic 2017-03-29 513 f4bd3b6a Chris Bostic 2017-03-29 @514 kfree(master); f4bd3b6a Chris Bostic 2017-03-29 515 } f4bd3b6a Chris Bostic 2017-03-29 516 f4bd3b6a Chris Bostic 2017-03-29 517 static int fsi_master_gpio_probe(struct platform_device *pdev) f4bd3b6a Chris Bostic 2017-03-29 518 { f4bd3b6a Chris Bostic 2017-03-29 519 struct fsi_master_gpio *master; f4bd3b6a Chris Bostic 2017-03-29 520 struct gpio_desc *gpio; f4bd3b6a Chris Bostic 2017-03-29 521 f4bd3b6a Chris Bostic 2017-03-29 522 master = devm_kzalloc(&pdev->dev, sizeof(*master), GFP_KERNEL); --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation